Skip to content

add description of connection.requested_server_name#1712

Merged
hklai merged 2 commits intoistio:masterfrom
vadimeisenbergibm:add_connection_requested_server_name_attribute
Jul 11, 2018
Merged

add description of connection.requested_server_name#1712
hklai merged 2 commits intoistio:masterfrom
vadimeisenbergibm:add_connection_requested_server_name_attribute

Conversation

@vadimeisenbergibm
Copy link
Contributor

@vadimeisenbergibm vadimeisenbergibm commented Jul 9, 2018

based on istio/api#575, part of istio/istio#6810

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 9, 2018
@istio-testing istio-testing requested review from frankbu and sdake July 9, 2018 16:20
@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vadimeisenbergibm
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake

Assign the PR to them by writing /assign @sdake in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vadimeisenbergibm vadimeisenbergibm changed the title [WIP] add description of connection.received.requested_server_name [WIP] add description of connection.requested_server_name Jul 10, 2018
@hklai hklai changed the title [WIP] add description of connection.requested_server_name add description of connection.requested_server_name Jul 11, 2018
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 11, 2018
@hklai hklai merged commit c465190 into istio:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants