Update metric expiry and cardinality docs to mention sidecar.istio.io/statsEvictionInterval and Telemetry resource#17043
Conversation
|
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @ringerc. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The tests are failing you need to run |
7fef343 to
4aec16c
Compare
|
@Ajay-singh1 Fixed, thanks |
fb671a4 to
d077f64
Compare
| in in-proxy telemetry for latency metrics at the lower latency levels. | ||
|
|
||
| * **No metric expiration for short-lived metrics** | ||
| * ~~**No metric expiration for short-lived metrics**~~ |
There was a problem hiding this comment.
We do not do strikethroughs. If you're striking through, typically means it no longer applies and should be removed.
There was a problem hiding this comment.
Updated. Better? I'd rather not remove the section completely, especially since expiry is not enabled by default.
804e905 to
e0336aa
Compare
In the documentation listing metrics and labels, list the names used to refer to these labels in configuration - and the actual label used in telemetry. Also link to the Telemetry API resource that can be used to customise them.
The FAQ on metric expiry and the telemetry v1 to v2 transition FAQ claim that metric expiry is not supported, but as-of the introduction of sidecar.istio.io/statsEvictionInterval in istio/istio#57736 this is no longer the case. API docs were added with the feature PR but other docs need updating to reflect that metrics may now be expired.
e0336aa to
8116e0d
Compare
… sidecar.istio.io/statsEvictionInterval and Telemetry resource into Chinese
… sidecar.istio.io/statsEvictionInterval and Telemetry resource into Chinese
…docs to mention sidecar.istio.io/statsEvictionInterval and Telemetry resource into Chinese (#17086) * Sync #17043 update metric expiry and cardinality docs to mention sidecar.istio.io/statsEvictionInterval and Telemetry resource into Chinese * fix lint --------- Co-authored-by: Wilson Wu <iwilsonwu@gmail.com>
Description
sidecar.istio.io/statsEvictionIntervalnow that support for metric expiry was added by telemetry: add bootstrap annotations for stats flush and eviction istio#57736Telemetryresource's features for overriding metrics and dimensions in the FAQ for metric cardinalityTelemetryresource and the docs for customising metrics in the reference docs for standard labelsReviewers