Skip to content

Conversation

@chriscattermole
Copy link
Contributor

Description

Fix incorrect value matching type descriptions in security docs - Suffix and Prefix

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

https://istio.io/latest/docs/concepts/security/#authorization

@chriscattermole chriscattermole requested a review from a team as a code owner October 16, 2025 12:26
Copilot AI review requested due to automatic review settings October 16, 2025 12:26
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 16, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: chriscattermole / name: Chris Cattermole (300ff46)

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Oct 16, 2025
@istio-testing
Copy link
Contributor

Hi @chriscattermole. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fix incorrect value matching type descriptions in security docs by correcting the definitions of prefix and suffix matches.

  • Swap and correct the descriptions for prefix vs. suffix matches
  • Minor formatting cleanup

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +713 to 716
- Suffix match: a string with an ending `"*"`. For example, `"test.abc.*"`
matches `"test.abc.com"`, `"test.abc.com.cn"`, `"test.abc.org"`, etc.
- Suffix match: a string with a starting `"*"`. For example, `"*.abc.com"`
- Prefix match: a string with a starting `"*"`. For example, `"*.abc.com"`
matches `"eng.abc.com"`, `"test.eng.abc.com"`, etc.
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definitions for prefix and suffix matches are reversed. Correct wording should be: 'Prefix match: a string with an ending "" (e.g., "test.abc.")' and 'Suffix match: a string with a starting "" (e.g., ".abc.com")'.

Copilot uses AI. Check for mistakes.

- Exact match: exact string match.
- Prefix match: a string with an ending `"*"`. For example, `"test.abc.*"`
- Suffix match: a string with an ending `"*"`. For example, `"test.abc.*"`
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra space between 'Suffix' and 'match'.

Suggested change
- Suffix match: a string with an ending `"*"`. For example, `"test.abc.*"`
- Suffix match: a string with an ending `"*"`. For example, `"test.abc.*"`

Copilot uses AI. Check for mistakes.
@dhawton dhawton added the cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch label Oct 16, 2025
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Oct 17, 2025
@istio-testing istio-testing merged commit 57c0b88 into istio:master Oct 17, 2025
6 checks passed
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request Oct 17, 2025
istio-testing pushed a commit that referenced this pull request Oct 20, 2025
istio-testing pushed a commit to istio-testing/istio.io that referenced this pull request Oct 20, 2025
dhawton pushed a commit to dhawton/istio-istio.io that referenced this pull request Oct 28, 2025
dhawton pushed a commit to dhawton/istio-istio.io that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick/release-1.27 Set this label on a PR to auto-merge it to the release-1.27 branch kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants