-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix incorrect match type descriptions in security docs #16935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
|
|
Hi @chriscattermole. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Fix incorrect value matching type descriptions in security docs by correcting the definitions of prefix and suffix matches.
- Swap and correct the descriptions for prefix vs. suffix matches
- Minor formatting cleanup
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - Suffix match: a string with an ending `"*"`. For example, `"test.abc.*"` | ||
| matches `"test.abc.com"`, `"test.abc.com.cn"`, `"test.abc.org"`, etc. | ||
| - Suffix match: a string with a starting `"*"`. For example, `"*.abc.com"` | ||
| - Prefix match: a string with a starting `"*"`. For example, `"*.abc.com"` | ||
| matches `"eng.abc.com"`, `"test.eng.abc.com"`, etc. |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definitions for prefix and suffix matches are reversed. Correct wording should be: 'Prefix match: a string with an ending "" (e.g., "test.abc.")' and 'Suffix match: a string with a starting "" (e.g., ".abc.com")'.
|
|
||
| - Exact match: exact string match. | ||
| - Prefix match: a string with an ending `"*"`. For example, `"test.abc.*"` | ||
| - Suffix match: a string with an ending `"*"`. For example, `"test.abc.*"` |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an extra space between 'Suffix' and 'match'.
| - Suffix match: a string with an ending `"*"`. For example, `"test.abc.*"` | |
| - Suffix match: a string with an ending `"*"`. For example, `"test.abc.*"` |
Arhell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
…x into Chinese
…x into Chinese
…x into Chinese (istio#16937)
Description
Fix incorrect value matching type descriptions in security docs - Suffix and Prefix
Reviewers
https://istio.io/latest/docs/concepts/security/#authorization