-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move ambient tests to ambient profile #15241
Merged
istio-testing
merged 1 commit into
istio:master
from
Nordix:add-ambient-tests-to-ambient-profile
Jun 4, 2024
Merged
move ambient tests to ambient profile #15241
istio-testing
merged 1 commit into
istio:master
from
Nordix:add-ambient-tests-to-ambient-profile
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faseela K <[email protected]>
istio-testing
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jun 4, 2024
dhawton
approved these changes
Jun 4, 2024
wilsonwu
added a commit
to wilsonwu/istio.io
that referenced
this pull request
Jun 5, 2024
11 tasks
istio-testing
pushed a commit
that referenced
this pull request
Jun 6, 2024
1 task
craigbox
pushed a commit
to craigbox/istio.io
that referenced
this pull request
Jun 26, 2024
Signed-off-by: Faseela K <[email protected]>
craigbox
pushed a commit
to craigbox/istio.io
that referenced
this pull request
Jun 27, 2024
Signed-off-by: Faseela K <[email protected]>
istio-testing
pushed a commit
that referenced
this pull request
Jun 28, 2024
* docs: break apart the ambient getting start guide (WIP) (#15168) * break apart the ambient getting start guide Signed-off-by: Peter Jausovec <[email protected]> * wip Signed-off-by: Peter Jausovec <[email protected]> * wip Signed-off-by: Peter Jausovec <[email protected]> * fix linter issues Signed-off-by: Peter Jausovec <[email protected]> * wip Signed-off-by: Peter Jausovec <[email protected]> * add tests Signed-off-by: Peter Jausovec <[email protected]> * Craig's first edits * lint fixes * Fix tests * fix tests * test for #15200 workaround * fix tests (thanks Faseela for helping me get them running locally!) * Fix the snip generator? * remove Wasm test because it depends on snips we're moving around * rebase go.mod properly * remove spelling * new screenshots + pr fixes Signed-off-by: Peter Jausovec <[email protected]> * can't test locally so let's hope * lint fixes * make gen & fix test * fixy testy * Fix snip * fix tests as we learn more * Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md Co-authored-by: Daniel Hawton <[email protected]> * fixing the wasm tests Signed-off-by: Peter Jausovec <[email protected]> --------- Signed-off-by: Peter Jausovec <[email protected]> Co-authored-by: Craig Box <[email protected]> Co-authored-by: Daniel Hawton <[email protected]> * cherrypick #15227 too * move ambient tests to ambient profile (#15241) Signed-off-by: Faseela K <[email protected]> * Manual cherry-pick the last of 15293 * Fix gencheck with release-1.22 versions of the tests * re-add setup snips to fix the tests again; there's no avoiding #15200 * Update content/en/docs/ambient/getting-started/test.sh --------- Signed-off-by: Peter Jausovec <[email protected]> Signed-off-by: Faseela K <[email protected]> Co-authored-by: Peter Jausovec <[email protected]> Co-authored-by: Daniel Hawton <[email protected]> Co-authored-by: Faseela K <[email protected]> Co-authored-by: Faseela K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have ambient profile, so let us use that for the ambient tests.
Reviewers