-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ambient beta get started guide patch #14805
Ambient beta get started guide patch #14805
Conversation
Co-authored-by: Frank Budinsky <[email protected]>
Co-authored-by: Frank Budinsky <[email protected]>
Co-authored-by: Frank Budinsky <[email protected]>
Hi @nauticalmike. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
You will need to enable the tests, removing the Pointer to Slack discussion on the test failure: https://istio.slack.com/archives/C049TCZMPCP/p1711387715045829 |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY! Wording SGTM, rest LGTM outside of @ericvn's comments
/retest |
@ericvn I'm hitting an issue here:
What should I do here? What I mean is on this step we are supposed to get an |
/retest |
Correct. This is the problem that moving up istio references causes breaking the tests. I'm not sure what the resolution should be, but see the discussion in Slack mentioned above with @ilrudie |
/retest |
Since this is mostly a wording fix and doctests seem to need a rework in the wake of the waypoint attach changes, suggest we leave the tests disabled here, and raise an issue to fix+enable the doctests. |
The tests are disabled and there already is a release blocker issue to enable and fix them: istio/istio#50145. What you need to do in this PR would be to not rename the disabled test back so that we are trying to run it, and likely only include any index.md changes you desire. Note that the doc will need to be reworked and test rewritten in the next few weeks as I believe 1.22 is planned for release in a month or so. |
/retest |
@nauticalmike: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -261,7 +261,7 @@ $ kubectl label namespace default istio.io/dataplane-mode=ambient | |||
Congratulations! You have successfully added all pods in the default namespace | |||
to the mesh. Note that you did not have to restart or redeploy anything! | |||
|
|||
Check once again the ztunnel logs for the proxy has received the network namespace (netns) information about an ambient application pod, and has started proxying for it: | |||
Check the ztunnel logs for the proxy has received the network namespace (netns) information about an ambient application pod, and has started proxying for it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the ztunnel logs for the proxy has received the network namespace (netns) information about an ambient application pod, and has started proxying for it: | |
Check the ztunnel logs to confirm the proxy has received the network namespace (netns) information about an application pod in ambient mode, and has started proxying for it: |
@nauticalmike please rebase and we can get the wording changes in separately from the test changes! |
I think the change we made to getting started in #15168 includes all of this so I'll close it with thanks! |
Description
Adjusting removing the inpod from doc per @bleggett 's suggestion #14788 (comment)
Reviewers