DNM Test with reference docs using Goldmark in istio/api #12086
Closed
ericvn wants to merge 3 commits intoistio:masterfrom
Closed
DNM Test with reference docs using Goldmark in istio/api #12086ericvn wants to merge 3 commits intoistio:masterfrom
ericvn wants to merge 3 commits intoistio:masterfrom
Conversation
Contributor
Author
|
Need to fix: found with |
Contributor
Author
|
Related to changes like:? |
Contributor
Author
|
Updated the markdown to add Unsafe and remove XHTML and hard breaks. Reran against api and to istio.io. |
Contributor
Author
in |
Contributor
Author
|
Close this PR as testing is hopefully complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please provide a description for what this PR is for.
Test deploy using updated tooling to generate with Goldmark instead of BlackFriday (istio/tools#2168).
Ran
make genagainst istio/api and then updated the docs from my repo's branch.