Http10 without keep-alive means close#74
Merged
jplevyak merged 6 commits intoistio:release-1.1from May 31, 2019
Merged
Conversation
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
lambdai
suggested changes
May 30, 2019
Signed-off-by: John Plevyak <jplevyak@gmail.com>
lambdai
approved these changes
May 30, 2019
| } else if (client.stream_wrapper_->saw_close_header_ || client.codec_client_->remoteClosed()) { | ||
| } else if (client.stream_wrapper_->saw_close_header_ || client.codec_client_->remoteClosed() || | ||
| (client.codec_client_->protocol() == Protocol::Http10 && | ||
| !client.stream_wrapper_->saw_keep_alive_header_)) { |
Author
There was a problem hiding this comment.
Added test. Note: this change broke a number of other tests because the test framework was using HTTP/1.0 and not setting keep-alive.
Those are now fixed as well.
PTAL
Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
approved these changes
May 30, 2019
| saw_close_header_ = true; | ||
| parent_.parent_.host_->cluster().stats().upstream_cx_close_notify_.inc(); | ||
| } | ||
| if (absl::EqualsIgnoreCase(headers->Connection()->value().getStringView(), |
Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
approved these changes
May 30, 2019
brian-avery
pushed a commit
that referenced
this pull request
Jun 30, 2020
Signed-off-by: Yan Avlasov <yavlasov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]