Fix connection reuse by delaying a poll cycle.#73
Merged
jplevyak merged 5 commits intoistio:release-1.1from May 31, 2019
Merged
Fix connection reuse by delaying a poll cycle.#73jplevyak merged 5 commits intoistio:release-1.1from
jplevyak merged 5 commits intoistio:release-1.1from
Conversation
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
|
@jplevyak The code looks good. I will build a proxy image. Could you add test cases before the merge? |
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
lambdai
suggested changes
May 30, 2019
lambdai
left a comment
lambdai
left a comment
There was a problem hiding this comment.
The delay client is not transforming itself to ready if there is no further delayed client.
Could you add another timer? See inline comment
And the test?
| if (client.delayed_ == 0) { | ||
| ENVOY_CONN_LOG(debug, "moving from delay to ready", *client.codec_client_); | ||
| client.moveBetweenLists(delayed_clients_, ready_clients_); | ||
| } |
There was a problem hiding this comment.
could you create another time here when
- the delayed_clients is not empty, and
- there is no pending timer
So that thedelayed clientscan be moved toreadyin next batch.
Signed-off-by: John Plevyak <jplevyak@gmail.com>
|
/lgtm |
|
/lgtm |
rlenglet
pushed a commit
that referenced
this pull request
Aug 13, 2019
* Add header size, response code and destination port Signed-off-by: Pengyuan Bian <bianpengyuan@google.com>
brian-avery
pushed a commit
that referenced
this pull request
Jun 30, 2020
Signed-off-by: Yan Avlasov <yavlasov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Plevyak jplevyak@gmail.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Delay connection reuse until we have done a poll cycle to detect closed connections.
Risk Level: low
Testing: hand
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue] envoyproxy#13848
[Optional Deprecated:]