Skip to content

test: add _cpp suffix to test data generated using C++ SDK.#44

Merged
PiotrSikora merged 3 commits intoistio:wasmfrom
PiotrSikora:wasm-cpp
Mar 14, 2019
Merged

test: add _cpp suffix to test data generated using C++ SDK.#44
PiotrSikora merged 3 commits intoistio:wasmfrom
PiotrSikora:wasm-cpp

Conversation

@PiotrSikora
Copy link

@PiotrSikora PiotrSikora commented Mar 14, 2019

Signed-off-by: Piotr Sikora piotrsikora@google.com

@PiotrSikora
test: add _cpp suffix to test data generated using C++ SDK.
706f15f 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora requested a review from jplevyak March 14, 2019 11:09
@istio-testing
Copy link

istio-testing commented Mar 14, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jplevyak
jplevyak reviewed Mar 14, 2019
View reviewed changes
Copy link

@jplevyak jplevyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't necessary, the wildcard rules fall through: see jplevyak@96e81d8

@PiotrSikora
Copy link
Author

PiotrSikora commented Mar 14, 2019

@jplevyak yeah, but then you'll end-up with conflict because of:

  • logging.cc -> logging.wasm,
  • logging.rs -> logging.wasm.

@jplevyak
Copy link

jplevyak commented Mar 14, 2019

Well, don't do that :) I am fine with doing this, I just wanted to point out that it wasn't necessary.

Feel free to merge.

@PiotrSikora
Copy link
Author

PiotrSikora commented Mar 14, 2019

I wanted to say "this only affects tests", but I've just realized that I modified the Makefile in SDK, which it indeed shouldn't be necessary. Let me fix that.

@PiotrSikora
Copy link
Author

PiotrSikora commented Mar 14, 2019

@jplevyak Fixed, PTAL.

@PiotrSikora PiotrSikora merged commit 098f146 into istio:wasm Mar 14, 2019
rlenglet pushed a commit that referenced this pull request Aug 13, 2019
@jplevyak
Add filter specific contexts and root contexts. (#44)
799eb77 
* Add filter specific contexts and root contexts.

Signed-off-by: John Plevyak <jplevyak@gmail.com>
brian-avery added a commit that referenced this pull request Sep 29, 2020
@brian-avery
[1.6] Fix CVE-2020-25017 (#44)
c9e9132 
* Apply patch 2

* patch 3

* Patch 4

* Fixing build failures

Co-authored-by: Dmitri Dolguikh <ddolguik@redhat.com>
istio-testing pushed a commit that referenced this pull request Oct 2, 2020
@brian-avery
[1.6] Fix CVE-2020-25017 (#44) (#267)
b118f52 
* Apply patch 2

* patch 3

* Patch 4

* Fixing build failures

Co-authored-by: Dmitri Dolguikh <ddolguik@redhat.com>

Co-authored-by: Dmitri Dolguikh <ddolguik@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jplevyak jplevyak jplevyak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PiotrSikora @istio-testing @jplevyak