Detect and make available Emscripten version from metadata.#31
Merged
jplevyak merged 2 commits intoistio:wasmfrom Mar 5, 2019
Merged
Detect and make available Emscripten version from metadata.#31jplevyak merged 2 commits intoistio:wasmfrom
jplevyak merged 2 commits intoistio:wasmfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jplevyak
force-pushed
the
wasm-emversion
branch
6 times, most recently
from
b2af047 to
cbdc517
Compare
PiotrSikora
suggested changes
Mar 4, 2019
PiotrSikora
approved these changes
Mar 5, 2019
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
One small nit, LGTM otherwise. Thanks!
| virtual void link(absl::string_view debug_name, bool needs_emscripten) PURE; | ||
|
|
||
| // Call the 'start' function or main() if there is no start funcition. | ||
| // Call the 'start' function and initialize globals. |
There was a problem hiding this comment.
Nit: I believe main() is still called in start(), isn't it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect and make available Emscripten version from metadata.