Skip to content

Disable building Envoy filter example in CI#295

Closed
tbarrella wants to merge 1 commit intoistio:masterfrom
tbarrella:example-build
Closed

Disable building Envoy filter example in CI#295
tbarrella wants to merge 1 commit intoistio:masterfrom
tbarrella:example-build

Conversation

@tbarrella
Copy link

See istio/istio#30484

Signed-off-by: Taylor Barrella <tabarr@google.com>
@bianpengyuan
Copy link

@tbarrella do you intent to target this to master branch and then cherry-pick this to release branches later?

@tbarrella
Copy link
Author

I think so since it's failing in both 1.7 and 1.8 (do we have an automated way of creating cherry picks for this repo?)

@bianpengyuan
Copy link

I don't think auto cherry-pick is set up for this repo. We don't really use master branch of this repo so I think it is fine to just make the change to release branches.

@tbarrella
Copy link
Author

Opened #296 and #297

@istio-testing
Copy link

@tbarrella: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-tsan_envoy 994e879 link /test test-tsan_envoy
test-asan_envoy 994e879 link /test test-asan_envoy
test-release_envoy 994e879 link /test test-release_envoy
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PiotrSikora
Copy link

Yeah, master branch is not even kept up to date in this repo, please only use release branches.

Could you also send this cherry-pick for 1.9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants