1.5 - Do not call into the VM unless the VM Context has been created.…#213
Merged
istio-testing merged 1 commit intoistio:release-1.5from May 13, 2020
brian-avery:update153
Merged
1.5 - Do not call into the VM unless the VM Context has been created.…#213istio-testing merged 1 commit intoistio:release-1.5from brian-avery:update153
istio-testing merged 1 commit intoistio:release-1.5from
brian-avery:update153
Conversation
…#22) * Ensure that the in VM Context is created before onDone is called. Signed-off-by: John Plevyak <jplevyak@gmail.com> * Update as per offline discussion. Signed-off-by: John Plevyak <jplevyak@gmail.com> * Set in_vm_context_created_ in onNetworkNewConnection. Signed-off-by: John Plevyak <jplevyak@gmail.com> * Add guards to other network calls. Signed-off-by: John Plevyak <jplevyak@gmail.com> * Fix common/wasm tests. Signed-off-by: John Plevyak <jplevyak@gmail.com> * Patch tests. Signed-off-by: John Plevyak <jplevyak@gmail.com>
PiotrSikora
approved these changes
May 12, 2020
fpesce
approved these changes
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#22)
Signed-off-by: John Plevyak jplevyak@gmail.com
Signed-off-by: John Plevyak jplevyak@gmail.com
Signed-off-by: John Plevyak jplevyak@gmail.com
Signed-off-by: John Plevyak jplevyak@gmail.com
Signed-off-by: John Plevyak jplevyak@gmail.com
Signed-off-by: John Plevyak jplevyak@gmail.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]