test: deflake RetryHostPredicateFilter#206
Closed
lambdai wants to merge 1 commit intoistio:release-1.6from
Closed
Conversation
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Author
|
hmm... upstream envoy test is passing bazel is patient |
|
This is different from the fix in upstream that you referred to... Why do we have a custom fix for istio/envoy? |
Author
|
Aha, upstream fix could be applied here. |
Author
|
The PR is created here first because the same test is not flaky at upstream. I find the root cause a little bit later. |
Author
|
Close this one and cherry-pick the upstream commit instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When waiting for any of the up streams available, we should not set a large number of duration for each upstream.
With this change, the test pass rate increase from 50% to 100% on my machine.
Not sure why the upstream envoy survives.
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]