Skip to content

wasm: remove unused "free" function. (#404) #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bianpengyuan merged 1 commit into from
Feb 24, 2020
Merged

wasm: remove unused "free" function. (#404) #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions source/extensions/common/wasm/wasm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ void Wasm::getFunctions() {
_GET(__wasm_call_ctors);

_GET(malloc);
_GET(free);
#undef _GET

#define _GET_PROXY(_fn) wasm_vm_->getFunction("proxy_" #_fn, &_fn##_);
Expand Down Expand Up @@ -252,8 +251,8 @@ void Wasm::getFunctions() {
_GET_PROXY(on_delete);
#undef _GET_PROXY

if (!malloc_ || !free_) {
throw WasmException("WASM missing malloc/free");
if (!malloc_) {
throw WasmException("WASM missing malloc");
}
}

Expand Down
1 change: 0 additions & 1 deletion source/extensions/common/wasm/wasm.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ class Wasm : public Logger::Loggable<Logger::Id::wasm>, public std::enable_share
WasmCallVoid<0> __wasm_call_ctors_;

WasmCallWord<1> malloc_;
WasmCallVoid<1> free_;

// Calls into the VM.
WasmCallWord<2> validate_configuration_;
Expand Down