[release-1.4] bazel: replace tclap mirror. (#9072)#122
Merged
howardjohn merged 1 commit intoistio:release-1.4from Nov 20, 2019
Merged
[release-1.4] bazel: replace tclap mirror. (#9072)#122howardjohn merged 1 commit intoistio:release-1.4from
howardjohn merged 1 commit intoistio:release-1.4from
Conversation
Description: Change (non-existent) https://github.com/eile/tclap/ to https://github.com/mirror/tclap/. I didn't validate the new mirror in any way, but the downloded release file sha256sum stays the same. In the future the releases should probably be downloaded from the real upstream. However the release 1.2.1 tarball from https://sourceforge.net/projects/tclap/files/ did not have the same sha256sum as the release file which Envoy uses. Risk Level: Medium Testing: N/A Docs Changes: N/A Release Notes: Fixes envoyproxy#9071 Signed-off-by: Ismo Puustinen <ismo.puustinen@intel.com> Signed-off-by: Yan Xue <yxyan@google.com>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
|
yxue
changed the title
howardjohn
approved these changes
Nov 20, 2019
Miss-you
pushed a commit
to Miss-you/envoy
that referenced
this pull request
Nov 17, 2020
translation deployment_types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Change (non-existent) https://github.com/eile/tclap/ to https://github.com/mirror/tclap/. I didn't validate the new mirror in any way, but the downloded release file sha256sum stays the same. In the future the releases should probably be downloaded from the real upstream. However the release 1.2.1 tarball from https://sourceforge.net/projects/tclap/files/ did not have the same sha256sum as the release file which Envoy uses.
Risk Level: Medium
Testing: N/A
Docs Changes: N/A
Release Notes:
Fixes envoyproxy#9071
Signed-off-by: Ismo Puustinen ismo.puustinen@intel.com
Signed-off-by: Yan Xue yxyan@google.com