Skip to content

Add features schema#71

Merged
istio-testing merged 2 commits intoistio:masterfrom
brian-avery:addSchemaValidationToEnhancements
May 17, 2021
Merged

Add features schema#71
istio-testing merged 2 commits intoistio:masterfrom
brian-avery:addSchemaValidationToEnhancements

Conversation

@brian-avery
Copy link
Copy Markdown
Member

@brian-avery brian-avery commented May 13, 2021

This adds a schema for validating features.yaml. It also separates maturity and maturityNotes such that maturity can be an enum and additional notes can be added if needed.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label May 13, 2021
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2021
@brian-avery brian-avery mentioned this pull request May 13, 2021
Merged
@brian-avery brian-avery force-pushed the addSchemaValidationToEnhancements branch from 36787d4 to 7ace679 Compare May 13, 2021 21:52
@brian-avery
Copy link
Copy Markdown
Member Author

brian-avery commented May 14, 2021

/cherrypick release-1.10

@istio-testing
Copy link
Copy Markdown

istio-testing commented May 14, 2021

@brian-avery: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2021
@brian-avery
Copy link
Copy Markdown
Member Author

brian-avery commented May 14, 2021

@linsun @smawson @nrjpoddar This will prevent the spacing and other issues we've had in features.yaml.

@istio-testing istio-testing merged commit 5e83937 into istio:master May 17, 2021
@istio-testing istio-testing mentioned this pull request May 17, 2021
Closed
@istio-testing
Copy link
Copy Markdown

istio-testing commented May 17, 2021

@brian-avery: new pull request created: #76

Details

In response to this:

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcberg dcberg Awaiting requested review from dcberg

@duderino duderino Awaiting requested review from duderino

@linsun linsun Awaiting requested review from linsun

@louiscryan louiscryan Awaiting requested review from louiscryan

@nrjpoddar nrjpoddar Awaiting requested review from nrjpoddar

1 more reviewer

@smawson smawson smawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brian-avery @istio-testing @smawson