-
Notifications
You must be signed in to change notification settings - Fork 608
Add steven as maintainer for UX #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Tagging relevant maintainers/WG leads: @therealmitchconnors @howardjohn @Stevenjin8 @ramaraochavali |
f5bebd3 to
a8c72ac
Compare
therealmitchconnors
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for UX!
|
I think we should take it step by step, becoming a UX maintainer first is a good start. +1 for UX. |
|
+1 to what @zirain said. Prefer to go 1 step at time. @hzxuzhonghu 's input also |
|
Fair point about one area at a time. That being said, it seems like networking would be more appropriate based on the PRs and reviews no (I'm looking at #1548 plus this PR as well) |
|
@zirain @ramaraochavali Thanks for your feedback. I'm curious if there is anything you would look for specifically when it comes to networking/ztunnel? I feel like I have a good number of contributions and reviews. Do I have to just do more? Be more active in issues? |
Yes. I think you are on the right track for networking. Ztunnel - I am not fully following. So @keithmattix or @howardjohn can comment. |
|
Thanks for the feedback, I've updated the PR to be just UX |
|
+1 |
zirain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
keithmattix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome Steven!
Hey folks, reopening #1548.
Last time, I got feedback that I wasn't reviewing enough PRs/involved enough in the community.
I believe I've addressed this:
I realize that these aren't specific, so here are some networking related PRs that I've been involved for networking:
Here are UX related ones:
And for ztunnel:
Please let me know if you have any feedback
I want to join the Istio org!