redirect shoud be child filed of HTTPRoute#839
redirect shoud be child filed of HTTPRoute#839idouba wants to merge 3 commits intoistio:masterfrom idouba:master
Conversation
|
Hi @idouba. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@rshriram: changing LGTM is restricted to assignees, and assigning you to the PR failed. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
Please fix circleci failure. |
|
Repo has unstaged changes. Re-run ./scripts/generate-protos.sh |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, idouba, rshriram The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hzxuzhonghu: changing LGTM is restricted to assignees, and only istio/api repo collaborators may be assigned issues. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andraxylia Done, pls help review it , thanks. |
|
@andraxylia Are we good to merge this? If so, can you create a cherry pick to the release-1.1 branch? Thanks. |
|
think this is already covered by #865 |
No description provided.