Skip to content

fix EnvoyFilter docs#838

Closed
theganyo wants to merge 11 commits intoistio:release-1.1from
theganyo:envoyfilter-doc-fix
Closed

fix EnvoyFilter docs#838
theganyo wants to merge 11 commits intoistio:release-1.1from
theganyo:envoyfilter-doc-fix

Conversation

@theganyo
Copy link
Copy Markdown
Member

@theganyo theganyo commented Mar 7, 2019

See issue: istio/istio#12313

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 7, 2019
@ozevren ozevren requested review from andraxylia and removed request for ozevren March 8, 2019 17:41
@andraxylia
Copy link
Copy Markdown
Contributor

andraxylia commented Mar 8, 2019

/lgtm
/approve

@andraxylia @rshriram
Hosts are not ignored in ServiceEntry for HTTPs (istio#833)
924f1e0 
* Hosts are not ignored in ServiceEntry for HTTPs

* Clarify

* Reword

* Generate protos

* Address code review comments

* Fix typo

* generate
kyessenov and others added 6 commits March 11, 2019 13:48
@kyessenov @rshriram
make mixer config marshal deterministic (istio#846)
0791ae6 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@geeknoid
Fix some doc errors. (istio#854)
7e7d6af 
This started out to just fix a bad link to unblock work on
istio.io, but I ended up fixing a bunch of typos/incorrect format
throughout.
@geeknoid
Fix two more broken links. (istio#856)
a68257e
@esnible @geeknoid
Fix CRD examples for release-1.1 (istio#859)
9dca77f
@hzxuzhonghu @rshriram
fix MeshNetworks demo (istio#841)
032fe83 
* fix MeshNetworks demo

* generate

* update
@rshriram @geeknoid
last minute doc fixes (istio#865)
c1e0c86 
Signed-off-by: Shriram Rajagopalan <rshriram@gmail.com>
@geeknoid
Copy link
Copy Markdown
Contributor

geeknoid commented Mar 19, 2019

@theganyo Please rebase and repush this PR. When changing a proro, you need to do "make" locally and check in any file that's been modified by the build.

Thanks.

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Mar 19, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Mar 19, 2019
@linsun
Copy link
Copy Markdown
Member

linsun commented Mar 19, 2019 •
edited
Loading

/approve
/lgtm
some of yours are covered by #865

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 19, 2019

@linsun: changing LGTM is restricted to assignees, and assigning you to the PR failed.

Details

In response to this:

/approve
/lgtm
some of yours are coverey by #865

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Mar 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andraxylia, linsun, theganyo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@theganyo
Copy link
Copy Markdown
Member Author

theganyo commented Mar 19, 2019

Merge went weird. Closing, will open new PR.

@theganyo theganyo closed this Mar 19, 2019
@theganyo theganyo deleted the envoyfilter-doc-fix branch March 19, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandarjog mandarjog Awaiting requested review from mandarjog

2 more reviewers

@rshriram rshriram rshriram approved these changes

@andraxylia andraxylia andraxylia approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andraxylia andraxylia

Labels

cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@theganyo @andraxylia @geeknoid @googlebot @linsun @istio-testing @rshriram @kyessenov @esnible @hzxuzhonghu