Skip to content

Doc fixes.#821

Merged
geeknoid merged 2 commits intoistio:release-1.1from
geeknoid:release-1.1
Feb 27, 2019
Merged

Doc fixes.#821
geeknoid merged 2 commits intoistio:release-1.1from
geeknoid:release-1.1

Conversation

@geeknoid
Copy link
Contributor

@geeknoid geeknoid commented Feb 26, 2019

No description provided.

@geeknoid geeknoid requested a review from frankbu February 26, 2019 19:25
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 26, 2019
@istio-testing
Copy link
Collaborator

istio-testing commented Feb 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geeknoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

frankbu
frankbu reviewed Feb 26, 2019
View reviewed changes
networking/v1alpha3/sidecar.proto Outdated
// VirtualServices from remote namespaces corresponding to the specified
// hosts will be imported. The service in a namespace can be a service in
// the service registry (e.g., a kubernetes or cloud foundry service) or
// the service registry (e.g., aKubernetes or cloud foundry service) or
Copy link
Contributor

@frankbu frankbu Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// the service registry (e.g., aKubernetes or cloud foundry service) or
// the service registry (e.g., a Kubernetes or cloud foundry service) or

frankbu
frankbu reviewed Feb 26, 2019
View reviewed changes
networking/v1alpha3/virtual_service.proto Outdated
// The following Kubernetes example routes all traffic by default to pods
// of the reviews service with label "version: v1" (i.e., subset v1), and
// some to subset v2, in a kubernetes environment.
// some to subset v2, in aKubernetes environment.
Copy link
Contributor

@frankbu frankbu Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// some to subset v2, in aKubernetes environment.
// some to subset v2, in a Kubernetes environment.

frankbu
frankbu reviewed Feb 26, 2019
View reviewed changes
policy/v1beta1/cfg.proto Outdated
//
// In the following example we define a `metrics` handler for the `prometheus` adapter.
// The example is in the form of a kubernetes resource:
// The example is in the form of aKubernetes resource:
Copy link
Contributor

@frankbu frankbu Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The example is in the form of aKubernetes resource:
// The example is in the form of a Kubernetes resource:

frankbu
frankbu reviewed Feb 26, 2019
View reviewed changes
policy/v1beta1/type.proto Outdated
import "google/protobuf/timestamp.proto";

// An instance field of type Value denotes that the expression for the field is of dynamic type and can evalaute to any
// An instance field of type Value denotes that the expression for the field is of dynamic type and can evaluatee to any
Copy link
Contributor

@frankbu frankbu Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// An instance field of type Value denotes that the expression for the field is of dynamic type and can evaluatee to any
// An instance field of type Value denotes that the expression for the field is of dynamic type and can evaluate to any

frankbu
frankbu reviewed Feb 26, 2019
View reviewed changes
policy/v1beta1/type.proto Outdated
}

// An instance field of type IPAddress denotes that the expression for the field must evalaute to
// An instance field of type IPAddress denotes that the expression for the field must evaluatee to
Copy link
Contributor

@frankbu frankbu Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// An instance field of type IPAddress denotes that the expression for the field must evaluatee to
// An instance field of type IPAddress denotes that the expression for the field must evaluate to

Copy link
Contributor

@frankbu frankbu Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole bunch more evaluatee

@geeknoid geeknoid merged commit f2e09a7 into istio:release-1.1 Feb 27, 2019
geeknoid pushed a commit that referenced this pull request Mar 9, 2019
@ozevren @geeknoid
Merge release-1.1 to master (#840)
5a79ba0 
* Doc fixes.

* Add high-level overview and diagrams for MCP (#805)

* document MCP

* add additional note on NACK behavior

* add a note about ignoring stale nonces

* Add envoy metrics service configuration to ProxyConfig (#803)

* Add envoy metrics service configuration to ProxyConfig

Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API.

* Update proto.lock

* Reorder metrics_service_address just after statsd_udp_address

* Update comment in the authN API to match with 1.1 behavior (#808)

* Rename metrics_service_address to clarify that it is for Envoy's API (#809)

Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API.

* Generate separate HTML page per proto under networking (#811)

* Generate separate pages for each networking proto

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* tweaks

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Fix interdoc references

* separate doc and go gen

* change dash to underscore

* fix

* more fixes

* makefile fix

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* remove bad target

* Revert "change dash to underscore"

This reverts commit 7fbced6.

* final update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Revert "Generate separate HTML page per proto under networking (#811)"

This reverts commit 5f14ead since it breaks the ability
to generate reference docs in istio.io

* Update to latest tools.

* Revert "Update to latest tools."

This reverts commit 231fadc which I accidentally pushed to the
wrong place.

* fix mcp update error diagram (#810)

* update istio/tools (#815)

* Revert "Revert "Generate separate HTML page per proto under networking (#811)"" (#818)

* Minor updates for building docker images. (#817)

* Add spell checking for docs. (#819)

* Add a bunch of words to the custom dictionary.

* Document exportTo restrictions (#820)

* Doc fixes. (#821)

* Proxy config: Add tls_certs_to_watch field (#824)

* Proxy config: Add tls_certs_to_watch field

* Address PR comment

* Revert "Proxy config: Add tls_certs_to_watch field (#824)" (#825)

This reverts commit e613e35.

* Update gateway and sidecar hosts doc (#826)

* Update gateway and sidecar hosts doc

* regen

* review comments

* Update API docs (service entry, gateway, sidecar) (#831)

* Update sidecar and gateway docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* gen docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update service entry

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* add configurable dns refresh rate to mesh for strict dns cluster,  (#832)

* add configurable dns refresh rate to mesh for strict dns cluster, issue #12181

* add lock file

* Post-merge generation
istio-testing pushed a commit that referenced this pull request Mar 21, 2019
@howardjohn @istio-testing
Merge release-1.1 into master (#872)
87afa02 
* Doc fixes.

* Add high-level overview and diagrams for MCP (#805)

* document MCP

* add additional note on NACK behavior

* add a note about ignoring stale nonces

* Add envoy metrics service configuration to ProxyConfig (#803)

* Add envoy metrics service configuration to ProxyConfig

Similar to the statsd sink config, this change is in preparation for adding support for the envoy metrics service API.

* Update proto.lock

* Reorder metrics_service_address just after statsd_udp_address

* Update comment in the authN API to match with 1.1 behavior (#808)

* Rename metrics_service_address to clarify that it is for Envoy's API (#809)

Since "metrics service" is so ambiguous, this change specifically denotes that the config is for Envoy's metrics service API. The comments also now link to detailed info about the metrics service API.

* Generate separate HTML page per proto under networking (#811)

* Generate separate pages for each networking proto

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* tweaks

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Fix interdoc references

* separate doc and go gen

* change dash to underscore

* fix

* more fixes

* makefile fix

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* remove bad target

* Revert "change dash to underscore"

This reverts commit 7fbced6.

* final update

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* Revert "Generate separate HTML page per proto under networking (#811)"

This reverts commit 5f14ead since it breaks the ability
to generate reference docs in istio.io

* Update to latest tools.

* Revert "Update to latest tools."

This reverts commit 231fadc which I accidentally pushed to the
wrong place.

* fix mcp update error diagram (#810)

* update istio/tools (#815)

* Revert "Revert "Generate separate HTML page per proto under networking (#811)"" (#818)

* Minor updates for building docker images. (#817)

* Add spell checking for docs. (#819)

* Add a bunch of words to the custom dictionary.

* Document exportTo restrictions (#820)

* Doc fixes. (#821)

* Proxy config: Add tls_certs_to_watch field (#824)

* Proxy config: Add tls_certs_to_watch field

* Address PR comment

* Revert "Proxy config: Add tls_certs_to_watch field (#824)" (#825)

This reverts commit e613e35.

* Update gateway and sidecar hosts doc (#826)

* Update gateway and sidecar hosts doc

* regen

* review comments

* Update API docs (service entry, gateway, sidecar) (#831)

* Update sidecar and gateway docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* gen docs

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* update service entry

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* updates

Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>

* add configurable dns refresh rate to mesh for strict dns cluster,  (#832)

* add configurable dns refresh rate to mesh for strict dns cluster, issue #12181

* add lock file

* Hosts are not ignored in ServiceEntry for HTTPs (#833)

* Hosts are not ignored in ServiceEntry for HTTPs

* Clarify

* Reword

* Generate protos

* Address code review comments

* Fix typo

* generate

* make mixer config marshal deterministic (#846)

Signed-off-by: Kuat Yessenov <kuat@google.com>

* Fix some doc errors. (#854)

This started out to just fix a bad link to unblock work on
istio.io, but I ended up fixing a bunch of typos/incorrect format
throughout.

* Fix two more broken links. (#856)

* Fix CRD examples for release-1.1 (#859)

* fix MeshNetworks demo (#841)

* fix MeshNetworks demo

* generate

* update

* last minute doc fixes (#865)

Signed-off-by: Shriram Rajagopalan <rshriram@gmail.com>

* Clarify comment for server_name field in Mixer oop auth config (#800)

* add mixerclient config to istio.io reference docs (#827)

* Envoyfilter docs fix (#867)

* Tweaks to get the mixer client config docs to be published. (#868)

* Change where the Mixer client docs are published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandarjog mandarjog Awaiting requested review from mandarjog

1 more reviewer

@frankbu frankbu frankbu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@geeknoid @istio-testing @frankbu @googlebot