-
Notifications
You must be signed in to change notification settings - Fork 606
Update comment for credentialName #786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -305,15 +305,18 @@ message Server { | |
| string ca_certificates = 5; | ||
|
|
||
| // The credentialName stands for a unique identifier that can be used | ||
| // to identify the serverCertificate, the privateKey and the | ||
| // CaCertificates associated with this server. Gateway workloads | ||
| // capable of fetching credentials from a remote credential store will | ||
| // be configured to retrive the credentials using this name, instead of | ||
| // using the file system paths specified above. The semantics of the | ||
| // name are platform dependent. In Kubernetes, the default Istio | ||
| // supplied credentail server expects the credentialName to match the | ||
| // name of the Kubernetes secret that holds the server certificate, the | ||
| // private key, and the CA certificate (if using mutual TLS). | ||
| // to identify the serverCertificate and the privateKey. The credentialName | ||
| // appended with suffix "-cacert" is used to identify the CaCertificates | ||
| // associated with this server. Gateway workloads capable of fetching | ||
| // credentials from a remote credential store will be configured to retrieve | ||
| // the serverCertificate and the privateKey using credentialName, instead of | ||
| // using the file system paths specified above. If using mutual TLS, | ||
| // gateway workloads will retrieve the CaCertificates using | ||
| // credentialName-cacert. The semantics of the name are platform dependent. | ||
| // In Kubernetes, the default Istio supplied credentail server expects the | ||
| // credentialName to match the name of the Kubernetes secret that holds the | ||
| // server certificate, the private key, and the CA certificate | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and if using mTLS, "credentialName-cacert" to match the name of the Kubernetes secret that holds the CA certificate.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If using mTLS, customer only creates one k8s secret with credentialName (e.g. "foo.credential"), Pilot creates two SDS configs for gateway listener, one is named "foo.credential", and is used to fetch key and cert. The other is named "foo.credential-cacert", and is used to fetch certificate validation context that has CA cert. So I think the comment is okay. |
||
| // (if using mutual TLS). | ||
| string credential_name = 10; | ||
|
|
||
| // A list of alternate names to verify the subject identity in the | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: credential