Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions networking/v1alpha3/istio.networking.v1alpha3.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

148 changes: 116 additions & 32 deletions networking/v1alpha3/service_entry.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions networking/v1alpha3/service_entry.proto
Original file line number Diff line number Diff line change
Expand Up @@ -461,4 +461,36 @@ message ServiceEntry {
// the annotation "networking.istio.io/export_to" to a comma-separated list
// of namespace names.
repeated string export_to = 7;

// $hide_from_docs
Comment thread
rshriram marked this conversation as resolved.
Outdated
// The set of service accounts identities allowed for workloads that
// implement this service. This information is used to enforce
// secure-naming <https://istio.io/docs/concepts/security/#secure-naming>.

// The following example illustrates the usage of a service account
// whose format conforms to the SPIFEE standard
// <https://github.com/spiffe/spiffe/blob/master/standards/SPIFFE-ID.md>:
//
// ```yaml
// apiVersion: networking.istio.io/v1alpha3
// kind: ServiceEntry
// metadata:
// name: httpbin
// namespace : httpbin-ns
// spec:
// hosts:
// - httpbin.com
// location: MESH_INTERNAL
// ports:
// - number: 80
// name: http
// protocol: HTTP
// resolution: STATIC
// endpoints:
// - address: 2.2.2.2
// - address: 3.3.3.3
// serviceAccounts:
// - "spiffe://cluster.local/ns/httpbin-ns/sa/httpbin-service-account"
// ```

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot add yamls and other stuff in the field docs. It will mess up the UI. Move this example and text to the area above message ServiceEntry. And keep the documentation here to a minimum, describing the intent of the field.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, ptal.

repeated string service_accounts = 8;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usual bike-shedding: service account is a k8s term.
We have the same setting in DestinationRule -> TLSSettings -> SubjectAltNames
The actual use is to indicate what SANs are exposed and/or should be expected by the endpoints.

Technically we can achieve the same by creating a synthetic DestinationRule, but it's getting too complicated.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to use the same nomenclature with existing, let me change it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the name.

We need to clarify what is the behavior if the user also configures a DestinationRule for the same service, with a different list of subject_alt_names. Do we want to override or merge? Override may cause auth failures, so merge seems to make more sense. Thoughts?

}
6 changes: 6 additions & 0 deletions proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3455,6 +3455,12 @@
"name": "export_to",
"type": "string",
"is_repeated": true
},
{
"id": 8,
"name": "service_accounts",
"type": "string",
"is_repeated": true
}
],
"messages": [
Expand Down
31 changes: 19 additions & 12 deletions python/istio_api/networking/v1alpha3/service_entry_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.