-
Notifications
You must be signed in to change notification settings - Fork 607
Add subject_alt_names field in ServiceEntry #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
a8d6d78
7492ac6
e53c7d5
bbf383d
ce63c70
6c33e7e
3968507
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -461,4 +461,36 @@ message ServiceEntry { | |
| // the annotation "networking.istio.io/export_to" to a comma-separated list | ||
| // of namespace names. | ||
| repeated string export_to = 7; | ||
|
|
||
| // $hide_from_docs | ||
| // The set of service accounts identities allowed for workloads that | ||
| // implement this service. This information is used to enforce | ||
| // secure-naming <https://istio.io/docs/concepts/security/#secure-naming>. | ||
|
|
||
| // The following example illustrates the usage of a service account | ||
| // whose format conforms to the SPIFEE standard | ||
| // <https://github.com/spiffe/spiffe/blob/master/standards/SPIFFE-ID.md>: | ||
| // | ||
| // ```yaml | ||
| // apiVersion: networking.istio.io/v1alpha3 | ||
| // kind: ServiceEntry | ||
| // metadata: | ||
| // name: httpbin | ||
| // namespace : httpbin-ns | ||
| // spec: | ||
| // hosts: | ||
| // - httpbin.com | ||
| // location: MESH_INTERNAL | ||
| // ports: | ||
| // - number: 80 | ||
| // name: http | ||
| // protocol: HTTP | ||
| // resolution: STATIC | ||
| // endpoints: | ||
| // - address: 2.2.2.2 | ||
| // - address: 3.3.3.3 | ||
| // serviceAccounts: | ||
| // - "spiffe://cluster.local/ns/httpbin-ns/sa/httpbin-service-account" | ||
| // ``` | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You cannot add yamls and other stuff in the field docs. It will mess up the UI. Move this example and text to the area above
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done, ptal. |
||
| repeated string service_accounts = 8; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Usual bike-shedding: service account is a k8s term. Technically we can achieve the same by creating a synthetic DestinationRule, but it's getting too complicated.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense to use the same nomenclature with existing, let me change it.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed the name. We need to clarify what is the behavior if the user also configures a DestinationRule for the same service, with a different list of subject_alt_names. Do we want to override or merge? Override may cause auth failures, so merge seems to make more sense. Thoughts? |
||
| } | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.