Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 124 additions & 33 deletions networking/v1alpha3/service_entry.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 34 additions & 0 deletions networking/v1alpha3/service_entry.proto
Original file line number Diff line number Diff line change
Expand Up @@ -461,4 +461,38 @@ message ServiceEntry {
// the annotation "networking.istio.io/export_to" to a comma-separated list
// of namespace names.
repeated string export_to = 7;

// $hide_from_docs
Comment thread
rshriram marked this conversation as resolved.
Outdated
// The list of subject alternate names allowed for workloads that
// implement this service. This information is used to enforce
// secure-naming <https://istio.io/docs/concepts/security/#secure-naming>.
// If specified, the proxy will verify that the server
// certificate's subject alternate name matches one of the specified values.
//
// The following example illustrates the usage of a subject alternate name
// whose format conforms to the SPIFEE standard
// <https://github.com/spiffe/spiffe/blob/master/standards/SPIFFE-ID.md>:
//
// ```yaml
// apiVersion: networking.istio.io/v1alpha3
// kind: ServiceEntry
// metadata:
// name: httpbin
// namespace : httpbin-ns
// spec:
// hosts:
// - httpbin.com
// location: MESH_INTERNAL
// ports:
// - number: 80
// name: http
// protocol: HTTP
// resolution: STATIC
// endpoints:
// - address: 2.2.2.2
// - address: 3.3.3.3
// subjectAltNames:
// - "spiffe://cluster.local/ns/httpbin-ns/sa/httpbin-service-account"
// ```

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot add yamls and other stuff in the field docs. It will mess up the UI. Move this example and text to the area above message ServiceEntry. And keep the documentation here to a minimum, describing the intent of the field.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, ptal.

repeated string subject_alt_names = 8;
}
6 changes: 6 additions & 0 deletions proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3455,6 +3455,12 @@
"name": "export_to",
"type": "string",
"is_repeated": true
},
{
"id": 8,
"name": "subject_alt_names",
"type": "string",
"is_repeated": true
}
],
"messages": [
Expand Down
31 changes: 19 additions & 12 deletions python/istio_api/networking/v1alpha3/service_entry_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.