Skip to content

Add subject_alt_names field in ServiceEntry #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenchenglu merged 7 commits into from
Feb 5, 2019
Merged

Add subject_alt_names field in ServiceEntry #785

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a8d6d78
Add service_accounts field in ServiceEntry
andraxylia Feb 4, 2019
7492ac6
Ran make proto-commit
andraxylia Feb 4, 2019
e53c7d5
Added example with format
andraxylia Feb 5, 2019
bbf383d
Rename to subject_alt_names
andraxylia Feb 5, 2019
ce63c70
Move example out of the message definition
andraxylia Feb 5, 2019
6c33e7e
Added a period
andraxylia Feb 5, 2019
3968507
Remove hide_from_docs
andraxylia Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions networking/v1alpha3/istio.networking.v1alpha3.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

125 changes: 93 additions & 32 deletions networking/v1alpha3/service_entry.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions networking/v1alpha3/service_entry.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,4 +461,8 @@ message ServiceEntry {
// the annotation "networking.istio.io/export_to" to a comma-separated list
// of namespace names.
repeated string export_to = 7;

// The reunion of service accounts associated with workloads

@nmittler nmittler Feb 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to describe what exact form this should take. It came up in the meeting today and I suspect there will be confusion for folks going forward. Would be good to try to make it clear now.

@louiscryan louiscryan Feb 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smawson - For TOC FYI even though this is not a user-visible API change, it affects contract between Pilot and Galley or other service registries

This should be marked $hidden_from_docs for the moment.

For documentation

"The set of service accounts identities allowed for workloads that implement this service. This information is used to enforce secure-naming (link https://istio.io/docs/concepts/security/#secure-naming)"

@andraxylia andraxylia Feb 5, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, added also an example with SA in SPIFEE format, ptal.

// backing this service
repeated string service_accounts = 8;

@costinm costinm Feb 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usual bike-shedding: service account is a k8s term.
We have the same setting in DestinationRule -> TLSSettings -> SubjectAltNames
The actual use is to indicate what SANs are exposed and/or should be expected by the endpoints.

Technically we can achieve the same by creating a synthetic DestinationRule, but it's getting too complicated.

@andraxylia andraxylia Feb 5, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to use the same nomenclature with existing, let me change it.

@andraxylia andraxylia Feb 5, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the name.

We need to clarify what is the behavior if the user also configures a DestinationRule for the same service, with a different list of subject_alt_names. Do we want to override or merge? Override may cause auth failures, so merge seems to make more sense. Thoughts?

}
6 changes: 6 additions & 0 deletions proto.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3455,6 +3455,12 @@
"name": "export_to",
"type": "string",
"is_repeated": true
},
{
"id": 8,
"name": "service_accounts",
"type": "string",
"is_repeated": true
}
],
"messages": [
Expand Down
31 changes: 19 additions & 12 deletions python/istio_api/networking/v1alpha3/service_entry_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.