Skip to content

Fix some spelling errors#745

Merged
istio-testing merged 1 commit intoistio:release-1.1from
JoeWrightss:patch-2
Jan 7, 2019
Merged

Fix some spelling errors#745
istio-testing merged 1 commit intoistio:release-1.1from
JoeWrightss:patch-2

Conversation

@JoeWrightss
Copy link
Copy Markdown
Contributor

Fix some spelling errors:

  1. "overriden" to "overridden".
  2. "assinged" to "assigned".

Signed-off-by: JoeWrightss <zhoulin.xie@daocloud.io>
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jan 2, 2019
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @JoeWrightss. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoeWrightss
Copy link
Copy Markdown
Contributor Author

/assign @kyessenov

@JoeWrightss
Copy link
Copy Markdown
Contributor Author

JoeWrightss commented Jan 2, 2019

I submits this PR against release-1.1 now, Thank you for guiding me🙂.

@hzxuzhonghu
Copy link
Copy Markdown
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 3, 2019
@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Jan 7, 2019

/lgtm
/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoeWrightss, ozevren

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 30cc0ae into istio:release-1.1 Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants