add field to global config for setting the access log format to text or json#660
add field to global config for setting the access log format to text or json#660rshriram merged 2 commits intoistio:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
mesh/v1alpha1/config.proto
Outdated
|
|
||
| // Format for the proxy access log (text or json). | ||
| // Default value is text. | ||
| string access_log_format = 24; |
There was a problem hiding this comment.
move this next to access_log_path, retain numbering.. Have a comment on top of this entire proto, with something like Next available field number: 25
Corresponding envoy PR: envoyproxy/envoy#4693
In istio deployments without mixer, logs must be in json format so they can be parsed by a scraper
Would make sense to have the new
access_log_formatfield by theaccess_log_filebut not sure if it's worth introducing the potential breaking change - feedback welcome