Skip to content

add field to global config for setting the access log format to text or json#660

Merged
rshriram merged 2 commits intoistio:masterfrom
GregHanson:access-log-format
Oct 19, 2018
Merged

add field to global config for setting the access log format to text or json#660
rshriram merged 2 commits intoistio:masterfrom
GregHanson:access-log-format

Conversation

@GregHanson
Copy link
Copy Markdown
Member

Corresponding envoy PR: envoyproxy/envoy#4693

In istio deployments without mixer, logs must be in json format so they can be parsed by a scraper

Would make sense to have the new access_log_format field by the access_log_file but not sure if it's worth introducing the potential breaking change - feedback welcome

@istio-testing istio-testing requested a review from diemtvu October 19, 2018 14:04
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Oct 19, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: frankbu

If they are not already assigned, you can assign the PR to them by writing /assign @frankbu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


// Format for the proxy access log (text or json).
// Default value is text.
string access_log_format = 24;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this next to access_log_path, retain numbering.. Have a comment on top of this entire proto, with something like Next available field number: 25

@rshriram rshriram merged commit ce64118 into istio:master Oct 19, 2018
@GregHanson GregHanson deleted the access-log-format branch October 22, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants