Skip to content

oop adapter connection auth config#606

Merged
mandarjog merged 2 commits intoistio:release-1.1from
bianpengyuan:grpc-adapter-auth
Dec 14, 2018
Merged

oop adapter connection auth config#606
mandarjog merged 2 commits intoistio:release-1.1from
bianpengyuan:grpc-adapter-auth

Conversation

@bianpengyuan
Copy link
Copy Markdown
Contributor

@bianpengyuan bianpengyuan commented Aug 8, 2018 •
edited
Loading

istio/istio#7637

@mandarjog This is a draft and I hope to get your early review. I am going to make a prototype with this config to make sure it works as expected. I've considered to reuse the TLSSettings, but it does not quite match oop adapter auth.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 8, 2018
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Aug 8, 2018
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Aug 8, 2018

cc @wattli

@bianpengyuan bianpengyuan force-pushed the grpc-adapter-auth branch 2 times, most recently from 3970169 to 5f73d84 Compare August 22, 2018 00:56
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Aug 22, 2018

@mandarjog I updated the config proto. ptal.

@mandarjog mandarjog self-requested a review September 4, 2018 20:28
mandarjog
mandarjog reviewed Sep 4, 2018
View reviewed changes
policy/v1beta1/cfg.proto Outdated

// Access token is passed to adapter as basic token (i.e. authorization:
// basic some-token).
BASIC = 1;
Copy link
Copy Markdown
Contributor

@mandarjog mandarjog Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get rid of Basic auth. we should keep api-key auth and oauth.

Copy link
Copy Markdown
Contributor Author

@bianpengyuan bianpengyuan Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bianpengyuan bianpengyuan changed the title [WIP] oop adapter connection auth config oop adapter connection auth config Oct 1, 2018
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Oct 1, 2018
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Oct 1, 2018

@mandarjog PTAL and let's check this in and start implementation in istio repo?

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Oct 3, 2018

@mandarjog gentle ping.

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Oct 25, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Oct 25, 2018
@bianpengyuan bianpengyuan changed the base branch from master to release-1.1 October 25, 2018 16:25
@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Oct 25, 2018

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Oct 25, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Oct 25, 2018
@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Oct 25, 2018

@mandarjog just rebased to 1.1. Ptal.

@bianpengyuan
Copy link
Copy Markdown
Contributor Author

bianpengyuan commented Dec 8, 2018

@mandarjog Any chance to take a look and check this in? :)

@mandarjog
Copy link
Copy Markdown
Contributor

mandarjog commented Dec 14, 2018

The design has been discussed in Authentication for Mixer-grpc Adapters design doc.

@mandarjog
Copy link
Copy Markdown
Contributor

mandarjog commented Dec 14, 2018

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Dec 14, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bianpengyuan, mandarjog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mandarjog mandarjog merged commit 80aff01 into istio:release-1.1 Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andraxylia andraxylia Awaiting requested review from andraxylia

@hklai hklai Awaiting requested review from hklai

1 more reviewer

@mandarjog mandarjog mandarjog left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mandarjog mandarjog

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bianpengyuan @googlebot @mandarjog @istio-testing