Merged
Conversation
googlebot
added
the
cla: yes
ayj
reviewed
Mar 6, 2018
mixer/v1/config/client/auth.proto
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // This policy API is still under development, and may be replaced by |
Contributor
There was a problem hiding this comment.
Replaced entirely or from user perspective? I thought this proto would continue to define auth filter configuration and your AuthenticationPolicy API would be the user-facing configuration.
cc @qiwzhang - are you planning to continue using this proto for auth filter, or move that elsewhere (e.g. proxy repo or upstream)?
Contributor
Author
ayj
approved these changes
Mar 21, 2018
incfly
pushed a commit
to incfly/api
that referenced
this pull request
Jun 13, 2018
* Clean up tcp filter attributes. * remove using namespace.
incfly
pushed a commit
to incfly/api
that referenced
this pull request
Jun 13, 2018
Automatic merge from submit-queue. [DO NOT MERGE] Auto PR to update dependencies of mixerclient This PR will be merged automatically once checks are successful. ```release-note none ```
nacx
pushed a commit
to nacx/api
that referenced
this pull request
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.