Skip to content

Cherrypick to release 1.7 Extend authorization policy action with 'Audit' action (#1552)#1622

Merged
istio-testing merged 1 commit intorelease-1.7from
cherrypick1.7
Sep 3, 2020
Merged

Cherrypick to release 1.7 Extend authorization policy action with 'Audit' action (#1552)#1622
istio-testing merged 1 commit intorelease-1.7from
cherrypick1.7

Conversation

@williamaronli
Copy link

@williamaronli williamaronli commented Sep 3, 2020

cherry-pick #1552 to release 1.7

@davidraskin @williamaronli
Extend authorization policy action with 'Audit' action (#1552)
1aa1aad 
* Modified rbac proto

* change module name

* change module again

* change go.mod again

* Changed back go.mod, go.sum, proto.lock

* Updated proto.lock

* Updated Audit documentation

* Documentation update

* Updated documentation
@williamaronli williamaronli requested a review from a team September 3, 2020 21:27
@googlebot
Copy link
Collaborator

googlebot commented Sep 3, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Sep 3, 2020
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 3, 2020
@williamaronli williamaronli added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Sep 3, 2020
@googlebot
Copy link
Collaborator

googlebot commented Sep 3, 2020

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@williamaronli
Copy link
Author

williamaronli commented Sep 3, 2020

@JimmyCYJ and @liminw please take a look at this PR

JimmyCYJ
JimmyCYJ approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@JimmyCYJ JimmyCYJ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with @liminw this does not change the current behavior of authorization policy.

@istio-testing istio-testing merged commit 8c43115 into release-1.7 Sep 3, 2020
@istio-testing istio-testing deleted the cherrypick1.7 branch September 3, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@liminw liminw liminw approved these changes

@JimmyCYJ JimmyCYJ JimmyCYJ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@liminw liminw

@JimmyCYJ JimmyCYJ

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@williamaronli @googlebot @liminw @JimmyCYJ @istio-testing @davidraskin