[release-1.26] Skip cleanup if control plane tests fail#978
Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.26from Jul 4, 2025
Merged
Conversation
Seems that this was missed in a recent refactor, so making sure the suite skips cleaning up when it failed and we want to keep the env. Use `ReportAfterSuite` which recieves a concentrated report and can tell if the suite has passed or failed. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.26 #978 +/- ##
================================================
+ Coverage 76.78% 76.93% +0.14%
================================================
Files 44 44
Lines 2679 2679
================================================
+ Hits 2057 2061 +4
+ Misses 527 524 -3
+ Partials 95 94 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fjglira
approved these changes
Jul 4, 2025
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jul 4, 2025
* upstream/release-1.26: [release-1.26] Cleaner improvements (istio-ecosystem#982) [release-1.26] Update VERSIONS_YAML_FILE e2e test information (istio-ecosystem#981) Skip cleanup if control plane tests fail (istio-ecosystem#978) Annotate only our clusters when using kind (istio-ecosystem#977) [release-1.26] Skip succeeded (istio-ecosystem#974) Fix Panic when creating ztunnel CR (istio-ecosystem#984)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Jul 4, 2025
* upstream/release-1.26: [release-1.26] Cleaner improvements (istio-ecosystem#982) [release-1.26] Update VERSIONS_YAML_FILE e2e test information (istio-ecosystem#981) Skip cleanup if control plane tests fail (istio-ecosystem#978) Annotate only our clusters when using kind (istio-ecosystem#977) [release-1.26] Skip succeeded (istio-ecosystem#974) Fix Panic when creating ztunnel CR (istio-ecosystem#984)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #910