Skip to content

Fix cleanup in multicluster tests #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 1 commit into from
Jun 16, 2025
Merged

Fix cleanup in multicluster tests #909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/e2e/multicluster/multicluster_suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,8 @@ var _ = BeforeSuite(func(ctx SpecContext) {
Success("Operator is deployed in the Remote namespace and Running")
})

var _ = AfterSuite(func(ctx SpecContext) {
if CurrentSpecReport().Failed() {
var _ = ReportAfterSuite("Condiotnal cleanup", func(ctx SpecContext, r Report) {
Copy link
Copy Markdown
Contributor

@sridhargaddam sridhargaddam Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the following PR to fix the small typo: #911

if !r.SuiteSucceeded {
if !debugInfoLogged {
common.LogDebugInfo(common.MultiCluster, k1, k2)
}
Expand Down