Skip to content

Deleting the Ambient resources#890

Closed
pbajjuri20 wants to merge 1 commit intomainfrom
pbaj_fix_ambient
Closed

Deleting the Ambient resources#890
pbajjuri20 wants to merge 1 commit intomainfrom
pbaj_fix_ambient

Conversation

@pbajjuri20
Copy link
Copy Markdown
Collaborator

If the first test case fails in the FIPS and IBM P&Z cluster, the resources are still available. However, the second test case is not running properly. If we cleanup the resources properly then the remaining test cases are running perfectly.

@pbajjuri20 pbajjuri20 requested a review from a team as a code owner June 9, 2025 18:35
@linux-foundation-easycla
Copy link
Copy Markdown

CLA Missing ID CLA Not Signed

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.16%. Comparing base (e42d3cd) to head (eb3e4ff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #890   +/-   ##
=======================================
  Coverage   76.16%   76.16%           
=======================================
  Files          44       44           
  Lines        2685     2685           
=======================================
  Hits         2045     2045           
  Misses        546      546           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pbajjuri20
Copy link
Copy Markdown
Collaborator Author

/retest

1 similar comment
@FilipB
Copy link
Copy Markdown
Collaborator

FilipB commented Jun 10, 2025

/retest

@istio-testing
Copy link
Copy Markdown
Collaborator

@pbajjuri20: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
e2e-kind_sail-operator_main eb3e4ff link true /test e2e-kind
e2e-kind-dualstack_sail-operator_main eb3e4ff link true /test e2e-kind-dualstack
e2e-kind-olm_sail-operator_main eb3e4ff link true /test e2e-kind-olm
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fjglira
Copy link
Copy Markdown
Contributor

fjglira commented Jun 10, 2025

Hey @pbajjuri20, this approach will not work when the test ends correctly without any issue because the resources do not exist anymore and are trying to be deleted. I suggest you wait until this PR is merged and add a new record for the cleaner to delete any dangling resources there

@pbajjuri20
Copy link
Copy Markdown
Collaborator Author

Thanks @fjglira :

this approach worked locally, the resources were deleted successfully and created the next test cases run perfectly. Sure will wait for the cleaner PR.

@pbajjuri20 pbajjuri20 closed this Jun 10, 2025
@pbajjuri20 pbajjuri20 deleted the pbaj_fix_ambient branch January 21, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants