enhancements: use issue ID's as SEP numbers#849
Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom May 26, 2025
Merged
enhancements: use issue ID's as SEP numbers#849istio-testing merged 1 commit intoistio-ecosystem:mainfrom
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
Conversation
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
- Coverage 76.47% 76.32% -0.16%
==========================================
Files 44 44
Lines 2640 2640
==========================================
- Hits 2019 2015 -4
- Misses 533 536 +3
- Partials 88 89 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fjglira
approved these changes
May 26, 2025
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
May 26, 2025
* upstream/main: enhancements: use issue ID's as SEP numbers (istio-ecosystem#849)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
May 26, 2025
* upstream/main: enhancements: use issue ID's as SEP numbers (istio-ecosystem#849)
fjglira
pushed a commit
to fjglira/sail-operator
that referenced
this pull request
Jun 2, 2025
Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com>
istio-testing
pushed a commit
that referenced
this pull request
Jun 3, 2025
* Add to vendors_default the possibility to add values for istiocni Signed-off-by: Francisco H <frherrer@redhat.com> * Fix lint Signed-off-by: Francisco H <frherrer@redhat.com> * Update test for vendors default Signed-off-by: Francisco H <frherrer@redhat.com> * Adding code coverage: new unit test over istiocni controller Signed-off-by: Francisco H <frherrer@redhat.com> * Update read me Signed-off-by: Francisco H <frherrer@redhat.com> * Skip succeeded (#842) * skip succeeded pods Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> * ut added to verify succeeded pods are skipped Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> --------- Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> Signed-off-by: Francisco H <frherrer@redhat.com> * enhancements: use issue ID's as SEP numbers (#849) Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Add unit test Signed-off-by: Francisco H <frherrer@redhat.com> * Update tests/e2e/README.md Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Update read me from review Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Gergo Huszty <gergo.huszty@digitaltrip.hu> Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
istio-testing
pushed a commit
to istio-testing/sail-operator
that referenced
this pull request
Jun 6, 2025
Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com>
fjglira
added a commit
to fjglira/sail-operator
that referenced
this pull request
Jun 11, 2025
…tio-ecosystem#845) * Add to vendors_default the possibility to add values for istiocni Signed-off-by: Francisco H <frherrer@redhat.com> * Fix lint Signed-off-by: Francisco H <frherrer@redhat.com> * Update test for vendors default Signed-off-by: Francisco H <frherrer@redhat.com> * Adding code coverage: new unit test over istiocni controller Signed-off-by: Francisco H <frherrer@redhat.com> * Update read me Signed-off-by: Francisco H <frherrer@redhat.com> * Skip succeeded (istio-ecosystem#842) * skip succeeded pods Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> * ut added to verify succeeded pods are skipped Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> --------- Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> Signed-off-by: Francisco H <frherrer@redhat.com> * enhancements: use issue ID's as SEP numbers (istio-ecosystem#849) Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Add unit test Signed-off-by: Francisco H <frherrer@redhat.com> * Update tests/e2e/README.md Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Update read me from review Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Gergo Huszty <gergo.huszty@digitaltrip.hu> Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
fjglira
added a commit
to fjglira/sail-operator
that referenced
this pull request
Jun 11, 2025
…tio-ecosystem#845) * Add to vendors_default the possibility to add values for istiocni Signed-off-by: Francisco H <frherrer@redhat.com> * Fix lint Signed-off-by: Francisco H <frherrer@redhat.com> * Update test for vendors default Signed-off-by: Francisco H <frherrer@redhat.com> * Adding code coverage: new unit test over istiocni controller Signed-off-by: Francisco H <frherrer@redhat.com> * Update read me Signed-off-by: Francisco H <frherrer@redhat.com> * Skip succeeded (istio-ecosystem#842) * skip succeeded pods Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> * ut added to verify succeeded pods are skipped Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> --------- Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> Signed-off-by: Francisco H <frherrer@redhat.com> * enhancements: use issue ID's as SEP numbers (istio-ecosystem#849) Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Add unit test Signed-off-by: Francisco H <frherrer@redhat.com> * Update tests/e2e/README.md Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Update read me from review Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Gergo Huszty <gergo.huszty@digitaltrip.hu> Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
istio-testing
pushed a commit
that referenced
this pull request
Jun 13, 2025
…) (#897) * Add to vendors_default the possibility to add values for istiocni * Fix lint * Update test for vendors default * Adding code coverage: new unit test over istiocni controller * Update read me * Skip succeeded (#842) * skip succeeded pods * ut added to verify succeeded pods are skipped --------- * enhancements: use issue ID's as SEP numbers (#849) * Add unit test * Update tests/e2e/README.md * Update read me from review --------- Signed-off-by: Francisco H <frherrer@redhat.com> Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Gergo Huszty <gergo.huszty@digitaltrip.hu> Co-authored-by: Daniel Grimm <dgrimm@redhat.com>
dgn
added a commit
to dgn/sail-operator
that referenced
this pull request
Mar 17, 2026
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
dgn
added a commit
to dgn/sail-operator
that referenced
this pull request
Mar 17, 2026
…tio-ecosystem#845) * Add to vendors_default the possibility to add values for istiocni Signed-off-by: Francisco H <frherrer@redhat.com> * Fix lint Signed-off-by: Francisco H <frherrer@redhat.com> * Update test for vendors default Signed-off-by: Francisco H <frherrer@redhat.com> * Adding code coverage: new unit test over istiocni controller Signed-off-by: Francisco H <frherrer@redhat.com> * Update read me Signed-off-by: Francisco H <frherrer@redhat.com> * Skip succeeded (istio-ecosystem#842) * skip succeeded pods Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> * ut added to verify succeeded pods are skipped Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> --------- Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> Signed-off-by: Francisco H <frherrer@redhat.com> * enhancements: use issue ID's as SEP numbers (istio-ecosystem#849) Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Add unit test Signed-off-by: Francisco H <frherrer@redhat.com> * Update tests/e2e/README.md Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Update read me from review Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Signed-off-by: Gergo Huszty <gergo.huszty@ibm.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com> Co-authored-by: Gergo Huszty <gergo.huszty@digitaltrip.hu> Co-authored-by: Daniel Grimm <dgrimm@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's how it's done with KEPs as well