Skip to content

fix: single-node cluster example in Istiod HA docs#1915

Merged
istio-testing merged 1 commit into
istio-ecosystem:mainfrom
chinaran:fix/istiod-ha-pdb
May 7, 2026
Merged

fix: single-node cluster example in Istiod HA docs#1915
istio-testing merged 1 commit into
istio-ecosystem:mainfrom
chinaran:fix/istiod-ha-pdb

Conversation

@chinaran
Copy link
Copy Markdown
Contributor

@chinaran chinaran commented May 7, 2026

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Update the Considerations for Single-Node Clusters example in docs/general/istiod-ha.adoc to place global.defaultPodDisruptionBudget under spec.values, matching the API reference and the correct Istio resource structure.

Signed-off-by: 王然 <ranwang@alauda.io>
@chinaran chinaran requested a review from a team as a code owner May 7, 2026 04:42
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @chinaran. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.63%. Comparing base (a39d566) to head (360fd9c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1915      +/-   ##
==========================================
+ Coverage   80.29%   80.63%   +0.34%     
==========================================
  Files          51       51              
  Lines        2598     2598              
==========================================
+ Hits         2086     2095       +9     
+ Misses        387      381       -6     
+ Partials      125      122       -3     
Flag Coverage Δ
integration-tests 71.34% <ø> (+0.39%) ⬆️
unit-tests 52.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@FilipB FilipB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@istio-testing istio-testing merged commit 9fa65a1 into istio-ecosystem:main May 7, 2026
16 of 17 checks passed
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request May 8, 2026
* upstream/main:
  Set DEPLOYMENT_NAME to csv name when OLM is true (istio-ecosystem#1918)
  fix: single-node cluster example in Istiod HA docs (istio-ecosystem#1915)
openshift-service-mesh-bot pushed a commit to openshift-service-mesh-bot/sail-operator that referenced this pull request May 11, 2026
* upstream/main:
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1916)
  Set DEPLOYMENT_NAME to csv name when OLM is true (istio-ecosystem#1918)
  fix: single-node cluster example in Istiod HA docs (istio-ecosystem#1915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants