Handle errors in Helm discovery client#1812
Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom Apr 10, 2026
Merged
Handle errors in Helm discovery client#1812istio-testing merged 1 commit intoistio-ecosystem:mainfrom
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
Conversation
This PR updates the helm discovery client to properly handle errors. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1812 +/- ##
==========================================
+ Coverage 80.87% 80.95% +0.07%
==========================================
Files 50 50
Lines 2494 2504 +10
==========================================
+ Hits 2017 2027 +10
Misses 351 351
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nrfox
approved these changes
Apr 10, 2026
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 13, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1820) Migrate from Helm v3 to Helm v4 (istio-ecosystem#1644) introduce crd-schema-checker (istio-ecosystem#1055) Add kubebuilder validation for revisionTagTargetRef (istio-ecosystem#1774) Handle errors in Helm discovery client (istio-ecosystem#1812) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1808)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 14, 2026
* upstream/main: Automator: Update EOL Istio versions in istio-ecosystem/sail-operator@main (istio-ecosystem#1821) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1820) Migrate from Helm v3 to Helm v4 (istio-ecosystem#1644) introduce crd-schema-checker (istio-ecosystem#1055) Add kubebuilder validation for revisionTagTargetRef (istio-ecosystem#1774) Handle errors in Helm discovery client (istio-ecosystem#1812) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1808)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 15, 2026
* upstream/main: Improve testing images tags for OLM and Operator images (istio-ecosystem#1819) Automator: Update EOL Istio versions in istio-ecosystem/sail-operator@main (istio-ecosystem#1821) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1820) Migrate from Helm v3 to Helm v4 (istio-ecosystem#1644) introduce crd-schema-checker (istio-ecosystem#1055) Add kubebuilder validation for revisionTagTargetRef (istio-ecosystem#1774) Handle errors in Helm discovery client (istio-ecosystem#1812) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1808)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 16, 2026
* upstream/main: Add helm.sh/helm/v3 to license allowlist alongside v4 (istio-ecosystem#1840) Update getLatestVersionByPrefix helm to v4 on update_deps.sh (istio-ecosystem#1833) Update kustomization files with registry.istio.io (istio-ecosystem#1829) Improve testing images tags for OLM and Operator images (istio-ecosystem#1819) Automator: Update EOL Istio versions in istio-ecosystem/sail-operator@main (istio-ecosystem#1821) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1820) Migrate from Helm v3 to Helm v4 (istio-ecosystem#1644) introduce crd-schema-checker (istio-ecosystem#1055) Add kubebuilder validation for revisionTagTargetRef (istio-ecosystem#1774) Handle errors in Helm discovery client (istio-ecosystem#1812) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1808)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 17, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1845) feat: add targetRef field to ZTunnel CRD (istio-ecosystem#1259) Add 1.29.2 and 1.28.6 versions (istio-ecosystem#1844) Use typed Go structs for FIPS values instead of helm.Values (istio-ecosystem#1695) Add helm.sh/helm/v3 to license allowlist alongside v4 (istio-ecosystem#1840) Update getLatestVersionByPrefix helm to v4 on update_deps.sh (istio-ecosystem#1833) Update kustomization files with registry.istio.io (istio-ecosystem#1829) Improve testing images tags for OLM and Operator images (istio-ecosystem#1819) Automator: Update EOL Istio versions in istio-ecosystem/sail-operator@main (istio-ecosystem#1821) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1820) Migrate from Helm v3 to Helm v4 (istio-ecosystem#1644) introduce crd-schema-checker (istio-ecosystem#1055) Add kubebuilder validation for revisionTagTargetRef (istio-ecosystem#1774) Handle errors in Helm discovery client (istio-ecosystem#1812) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1808)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 20, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1851) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1850) Add documentation for resource customization (istio-ecosystem#1292) refactor error and status condition handling (istio-ecosystem#1807) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1848) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1845) feat: add targetRef field to ZTunnel CRD (istio-ecosystem#1259) Add 1.29.2 and 1.28.6 versions (istio-ecosystem#1844) Use typed Go structs for FIPS values instead of helm.Values (istio-ecosystem#1695) Add helm.sh/helm/v3 to license allowlist alongside v4 (istio-ecosystem#1840) Update getLatestVersionByPrefix helm to v4 on update_deps.sh (istio-ecosystem#1833) Update kustomization files with registry.istio.io (istio-ecosystem#1829) Improve testing images tags for OLM and Operator images (istio-ecosystem#1819) Automator: Update EOL Istio versions in istio-ecosystem/sail-operator@main (istio-ecosystem#1821) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1820) Migrate from Helm v3 to Helm v4 (istio-ecosystem#1644) introduce crd-schema-checker (istio-ecosystem#1055) Add kubebuilder validation for revisionTagTargetRef (istio-ecosystem#1774) Handle errors in Helm discovery client (istio-ecosystem#1812) Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1808)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the helm discovery client to properly handle errors.