[release-1.27] Platform helm value is no longer used and needed + set OCP default value to false#1796
Merged
istio-testing merged 2 commits intoistio-ecosystem:release-1.27from Apr 7, 2026
Conversation
51267bb to
0df7ef4
Compare
Platform value is not used anywhere as the automatic detection was introduced in istio-ecosystem#434 Signed-off-by: Filip Brychta <fbrychta@redhat.com>
We are running everything in kind in upstream so we need OCP to be set to false. We will need to set it to true in the midstream repo. Signed-off-by: Filip Brychta <fbrychta@redhat.com>
0df7ef4 to
0252936
Compare
fjglira
approved these changes
Apr 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.27 #1796 +/- ##
================================================
+ Coverage 80.94% 81.11% +0.17%
================================================
Files 44 44
Lines 2304 2304
================================================
+ Hits 1865 1869 +4
+ Misses 322 319 -3
+ Partials 117 116 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 7, 2026
* upstream/release-1.27: [release-1.27] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1771) [release-1.27] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1796) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 7, 2026
* upstream/release-1.27: [release-1.27] Fix ztunel version in samples and bundle alm-examples (istio-ecosystem#1771) [release-1.27] Platform helm value is no longer used and needed + set OCP default value to false (istio-ecosystem#1796) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1770