[release-1.0] Fix infinite reconciliation on webhook resources#1671
Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.0from Apr 9, 2026
Merged
[release-1.0] Fix infinite reconciliation on webhook resources#1671istio-testing merged 1 commit intoistio-ecosystem:release-1.0from
istio-testing merged 1 commit intoistio-ecosystem:release-1.0from
Conversation
istiod updates the CABundle and FailurePolicy on its ValidatingWebhookConfigurations and MutatingWebhookConfigurations. The controller needs to ignore those changes to avoid continuous reconciliation of the control plane. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.0 #1671 +/- ##
===============================================
+ Coverage 75.64% 75.89% +0.24%
===============================================
Files 43 43
Lines 2086 2091 +5
===============================================
+ Hits 1578 1587 +9
+ Misses 414 411 -3
+ Partials 94 93 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
/retest |
fjglira
approved these changes
Apr 1, 2026
Collaborator
|
/retest |
Collaborator
|
/test e2e-kind |
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 9, 2026
* upstream/release-1.0: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1671)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 9, 2026
* upstream/release-1.0: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1671)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Apr 10, 2026
* upstream/release-1.0: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1671)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1658.
Cherry-pick of #1651.