[release-1.26] Fix infinite reconciliation on webhook resources#1670
Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.26from Mar 10, 2026
Merged
[release-1.26] Fix infinite reconciliation on webhook resources#1670istio-testing merged 1 commit intoistio-ecosystem:release-1.26from
istio-testing merged 1 commit intoistio-ecosystem:release-1.26from
Conversation
istiod updates the CABundle and FailurePolicy on its ValidatingWebhookConfigurations and MutatingWebhookConfigurations. The controller needs to ignore those changes to avoid continuous reconciliation of the control plane. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.26 #1670 +/- ##
================================================
+ Coverage 78.26% 78.62% +0.36%
================================================
Files 44 44
Lines 2227 2232 +5
================================================
+ Hits 1743 1755 +12
+ Misses 373 368 -5
+ Partials 111 109 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sridhargaddam
approved these changes
Mar 10, 2026
Collaborator
Author
|
/retest |
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 10, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 10, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 10, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 11, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 11, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 11, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 11, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 11, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 11, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 12, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 12, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Mar 12, 2026
* upstream/release-1.26: Fix infinite reconciliation on webhook resources (istio-ecosystem#1651) (istio-ecosystem#1670)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1651.
Closes #1657.