Fix panic by avoiding Expect inside Eventually#1595
Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom Feb 12, 2026
Merged
Fix panic by avoiding Expect inside Eventually#1595istio-testing merged 1 commit intoistio-ecosystem:mainfrom
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
Conversation
The control plane tests were using Expect() inside Eventually which was causing panic and test failure on the first error, defeating the purpose of Eventually's retry mechanism. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
dgn
approved these changes
Feb 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
- Coverage 80.73% 80.65% -0.09%
==========================================
Files 50 50
Lines 2466 2466
==========================================
- Hits 1991 1989 -2
- Misses 349 350 +1
- Partials 126 127 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 12, 2026
* upstream/main: Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 12, 2026
* upstream/main: Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 12, 2026
* upstream/main: Fix scorecard test failure (istio-ecosystem#1598) Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 12, 2026
* upstream/main: Fix scorecard test failure (istio-ecosystem#1598) Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 13, 2026
* upstream/main: Fix scorecard test failure (istio-ecosystem#1598) Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 13, 2026
* upstream/main: Fix scorecard test failure (istio-ecosystem#1598) Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 13, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1599) Fix scorecard test failure (istio-ecosystem#1598) Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 13, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1599) Fix scorecard test failure (istio-ecosystem#1598) Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 13, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1599) Fix scorecard test failure (istio-ecosystem#1598) Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 13, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1599) Fix scorecard test failure (istio-ecosystem#1598) Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 13, 2026
* upstream/main: Automator: Update dependencies in istio-ecosystem/sail-operator@main (istio-ecosystem#1599) Fix scorecard test failure (istio-ecosystem#1598) Fix panic by avoiding Expect inside Eventually (istio-ecosystem#1595) Make sure that FipsEnabled is restored to original value Enable TLSv1.2 for ZTunnel when in FIPS mode
dgn
pushed a commit
to dgn/sail-operator
that referenced
this pull request
Mar 17, 2026
The control plane tests were using Expect() inside Eventually which was causing panic and test failure on the first error, defeating the purpose of Eventually's retry mechanism. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control plane tests were using Expect() inside Eventually which was causing panic and test failure on the first error, defeating the purpose of Eventually's retry mechanism.