[Release-1.28] Manual Cherry-pick: Fix e2e midstream CI mode (#1564)#1582
Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from Feb 10, 2026
Merged
[Release-1.28] Manual Cherry-pick: Fix e2e midstream CI mode (#1564)#1582istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
Conversation
* Adding some fix for midstream CI execution Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Forcing avoid the use of external registry when CI mode is detected Adding a new variable to handle properly the case Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com>
FilipB
approved these changes
Feb 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #1582 +/- ##
================================================
- Coverage 81.03% 80.77% -0.27%
================================================
Files 44 44
Lines 2299 2299
================================================
- Hits 1863 1857 -6
- Misses 321 324 +3
- Partials 115 118 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
istio-testing
merged commit 85d6a24
into
istio-ecosystem:release-1.28
18 of 19 checks passed
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Feb 11, 2026
* upstream/release-1.28: [release-1.28] Improve scorecard test to avoid running on kind cluster inside OCP cl… (istio-ecosystem#1592) [release-1.28] Adding TARGET_ARCH to tag definition when run on CI true (istio-ecosystem#1586) Fix e2e midstream CI mode (istio-ecosystem#1564) (istio-ecosystem#1582)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some fix for midstream CI execution
Forcing avoid the use of external registry when CI mode is detected
Adding a new variable to handle properly the case
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #1566
Fixes #1568
Related Issue/PR #
Additional information: