Skip to content

[release-1.28] Add Istio 1.28.3 + bump operator version#1533

Closed
rafaelvzago wants to merge 0 commit intoistio-ecosystem:mainfrom
rafaelvzago:release-1.28.3-prep
Closed

[release-1.28] Add Istio 1.28.3 + bump operator version#1533
rafaelvzago wants to merge 0 commit intoistio-ecosystem:mainfrom
rafaelvzago:release-1.28.3-prep

Conversation

@rafaelvzago
Copy link
Copy Markdown
Contributor

@rafaelvzago rafaelvzago commented Jan 22, 2026

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

  • bumps operator version to 1.28.3
  • updates PREVIOUS_VERSION to 1.28.2
  • adds Istio 1.28.3
  • updates deps
  • uses correct istio mod - go get -u istio.io/istio@1.28.3

Which issue(s) this PR fixes:

Fixes #1532

Related Issue/PR #1435

Additional information:

This is a z-stream release to add Istio 1.28.3 support to the Sail Operator release-1.28 branch.

@rafaelvzago rafaelvzago requested a review from a team as a code owner January 22, 2026 19:33
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 22, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jan 22, 2026

Hi @rafaelvzago. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rafaelvzago rafaelvzago mentioned this pull request Jan 22, 2026
Closed
5 tasks
@rafaelvzago rafaelvzago force-pushed the release-1.28.3-prep branch 2 times, most recently from f375661 to ab1b729 Compare January 22, 2026 19:40
@rafaelvzago rafaelvzago marked this pull request as draft January 22, 2026 19:45
fjglira
fjglira reviewed Jan 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some issues related to the steps run and the branch status when the update dependencies was run. PLease take a look to the comment, but I think that is the root cause

.claude/commands/update-eol-versions.md
Copy link
Copy Markdown
Contributor

@fjglira fjglira Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, this file is already part of the repository: https://github.com/istio-ecosystem/sail-operator/blob/main/.claude/commands/update-eol-versions.md

.devcontainer/devcontainer.json Outdated
{
"name": "istio build-tools",
"image": "gcr.io/istio-testing/build-tools:master-116bd1273dfc5d27136461597f5ff54f535f416b",
"image": "gcr.io/istio-testing/build-tools:release-1.28-2cff97d3b27d82d78c5d4e468a467f520cf2fbf3",
Copy link
Copy Markdown
Contributor

@fjglira fjglira Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes should not be done in master. Because you are attaching a release branch build-tools image to master branch. We should keep on master. This was done by the update dependencies jobs?

api/v1/istio_types.go Outdated
// Must be one of: v1.28-latest, v1.28.3, v1.28.2, v1.28.1, v1.28.0, v1.27-latest, v1.27.5, v1.27.4, v1.27.3, v1.27.2, v1.27.1, v1.27.0, master, v1.30-alpha.702493a1.
// +operator-sdk:csv:customresourcedefinitions:type=spec,order=1,displayName="Istio Version",xDescriptors={"urn:alm:descriptor:com.tectonic.ui:fieldGroup:General", "urn:alm:descriptor:com.tectonic.ui:select:v1.28-latest", "urn:alm:descriptor:com.tectonic.ui:select:v1.28.3", "urn:alm:descriptor:com.tectonic.ui:select:v1.28.2", "urn:alm:descriptor:com.tectonic.ui:select:v1.28.1", "urn:alm:descriptor:com.tectonic.ui:select:v1.28.0", "urn:alm:descriptor:com.tectonic.ui:select:v1.27-latest", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.5", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.4", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.3", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.2", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.1", "urn:alm:descriptor:com.tectonic.ui:select:v1.27.0", "urn:alm:descriptor:com.tectonic.ui:select:master", "urn:alm:descriptor:com.tectonic.ui:select:v1.30-alpha.702493a1"}
// +kubebuilder:validation:Enum=v1.28-latest;v1.28.3;v1.28.2;v1.28.1;v1.28.0;v1.27-latest;v1.27.5;v1.27.4;v1.27.3;v1.27.2;v1.27.1;v1.27.0;v1.26-latest;v1.26.8;v1.26.7;v1.26.6;v1.26.5;v1.26.4;v1.26.3;v1.26.2;v1.26.1;v1.26.0;v1.25-latest;v1.25.5;v1.25.4;v1.25.3;v1.25.2;v1.25.1;v1.24-latest;v1.24.6;v1.24.5;v1.24.4;v1.24.3;v1.24.2;v1.24.1;v1.24.0;v1.23-latest;v1.23.6;v1.23.5;v1.23.4;v1.23.3;v1.23.2;v1.22-latest;v1.22.8;v1.22.7;v1.22.6;v1.22.5;v1.21.6;master;v1.30-alpha.702493a1
// Must be one of: v1.28-latest, v1.28.3, v1.28.2, v1.28.1, v1.28.0, v1.27-latest, v1.27.5, v1.27.4, v1.27.3, v1.27.2, v1.27.1, v1.27.0, v1.26-latest, v1.26.8, v1.26.7, v1.26.6, v1.26.5, v1.26.4, v1.26.3, v1.26.2, v1.26.1, v1.26.0.
Copy link
Copy Markdown
Contributor

@fjglira fjglira Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the update script was run not from latest changes in master, because I see that this is adding again 1.26 and 1.26 is EOL and already was merged the EOL in the master branch of this repo

@rafaelvzago rafaelvzago mentioned this pull request Jan 23, 2026
Closed
6 tasks
@rafaelvzago rafaelvzago deleted the release-1.28.3-prep branch January 23, 2026 18:07
This was referenced Jan 23, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjglira fjglira fjglira left review comments

Assignees

No one assigned

Labels

do-not-merge/work-in-progress needs-ok-to-test needs-rebase size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Sail Operator to Istio 1.28.3

3 participants

@rafaelvzago @istio-testing @fjglira