Skip to content

[release-1.28] Add support for pinning tool versions to minor releases (#1421)#1430

Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
FilipB:release-1.28-pin-tools
Dec 10, 2025
Merged

[release-1.28] Add support for pinning tool versions to minor releases (#1421)#1430
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from
FilipB:release-1.28-pin-tools

Conversation

@FilipB
Copy link
Copy Markdown
Collaborator

@FilipB FilipB commented Dec 10, 2025

  • Add support for pinning tool versions to minor releases
  • Add PIN_MINOR flag to only update patch versions while keeping major.minor the same
  • Add TOOLS_ONLY flag to skip Istio updates and only update tools
  • Remove kube-rbac-proxy update as it's no longer needed

🤖 Generated with Claude Code

  • Make the linter happy

  • Fix regex for getLatestMinorVersion and rename it to make better sense


What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

…tem#1421)

* Add support for pinning tool versions to minor releases

- Add PIN_MINOR flag to only update patch versions while keeping major.minor the same
- Add TOOLS_ONLY flag to skip Istio updates and only update tools
- Remove kube-rbac-proxy update as it's no longer needed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Filip Brychta <fbrychta@redhat.com>

* Make the linter happy

Signed-off-by: Filip Brychta <fbrychta@redhat.com>

* Fix regex for getLatestMinorVersion and rename it to make better sense

Signed-off-by: Filip Brychta <fbrychta@redhat.com>

---------

Signed-off-by: Filip Brychta <fbrychta@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Filip Brychta <fbrychta@redhat.com>
@FilipB FilipB requested a review from a team as a code owner December 10, 2025 10:19
@FilipB FilipB changed the title Add support for pinning tool versions to minor releases (#1421) [release-1.28] Add support for pinning tool versions to minor releases (#1421) Dec 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.77%. Comparing base (776961a) to head (ebb5207).
⚠️ Report is 1 commits behind head on release-1.28.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.28    #1430      +/-   ##
================================================
+ Coverage         80.64%   80.77%   +0.13%     
================================================
  Files                44       44              
  Lines              2299     2299              
================================================
+ Hits               1854     1857       +3     
+ Misses              327      324       -3     
  Partials            118      118              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question @FilipB: So, for this branch we are going to run the update with TOOLS_ONLY true?

@fjglira
Copy link
Copy Markdown
Contributor

fjglira commented Dec 10, 2025

Question @FilipB: So, for this branch we are going to run the update with TOOLS_ONLY true?

Never mind, I see it here: https://github.com/istio-ecosystem/sail-operator/pull/1424/files

@istio-testing istio-testing merged commit a2c410f into istio-ecosystem:release-1.28 Dec 10, 2025
19 checks passed
rafaelvzago pushed a commit to rafaelvzago/sail-operator that referenced this pull request Jan 22, 2026
…tem#1421) (istio-ecosystem#1430)

* Add support for pinning tool versions to minor releases

- Add PIN_MINOR flag to only update patch versions while keeping major.minor the same
- Add TOOLS_ONLY flag to skip Istio updates and only update tools
- Remove kube-rbac-proxy update as it's no longer needed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

* Make the linter happy

* Fix regex for getLatestMinorVersion and rename it to make better sense

---------

Signed-off-by: Filip Brychta <fbrychta@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
Signed-off-by: Rafael Zago <rafaelvzago@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants