Fix issues in the e2e samples readme file#1415
Merged
istio-testing merged 1 commit intoistio-ecosystem:mainfrom Dec 1, 2025
Merged
Fix issues in the e2e samples readme file#1415istio-testing merged 1 commit intoistio-ecosystem:mainfrom
istio-testing merged 1 commit intoistio-ecosystem:mainfrom
Conversation
This PR includes the following changes 1. Corrects the kubectl command to use the kustomization directory 2. Updates the make target that publishes sample images to quay.io/sail-dev 3. Fixes broken links Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
=======================================
Coverage 80.94% 80.94%
=======================================
Files 44 44
Lines 2299 2299
=======================================
Hits 1861 1861
Misses 322 322
Partials 116 116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mkolesnik
approved these changes
Nov 30, 2025
MaxBab
approved these changes
Nov 30, 2025
fjglira
approved these changes
Dec 1, 2025
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Dec 1, 2025
* upstream/main: Fix issues in the e2e samples readme file (istio-ecosystem#1415)
dgn
pushed a commit
to dgn/sail-operator
that referenced
this pull request
Mar 17, 2026
This PR includes the following changes 1. Corrects the kubectl command to use the kustomization directory 2. Updates the make target that publishes sample images to quay.io/sail-dev 3. Fixes broken links Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes