[release-1.28] Fix make gen errors when vendor folder is present#1359
Merged
istio-testing merged 1 commit intoistio-ecosystem:release-1.28from Nov 18, 2025
Conversation
When vendor mode is enabled in this project, the command "go list" can return an empty string, causing errors while running "make gen" command. This PR modifies the command to use "-mod=readonly" which ensures the Go command properly resolves the module directory even when vendoring is in use. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
bmangoen
approved these changes
Nov 18, 2025
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## release-1.28 #1359 +/- ##
================================================
- Coverage 80.38% 70.73% -9.65%
================================================
Files 44 39 -5
Lines 2299 2040 -259
================================================
- Hits 1848 1443 -405
- Misses 330 429 +99
- Partials 121 168 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/test unit-tests |
istio-testing
merged commit fcda57e
into
istio-ecosystem:release-1.28
17 of 19 checks passed
rafaelvzago
pushed a commit
to rafaelvzago/sail-operator
that referenced
this pull request
Jan 22, 2026
When vendor mode is enabled in this project, the command "go list" can return an empty string, causing errors while running "make gen" command. This PR modifies the command to use "-mod=readonly" which ensures the Go command properly resolves the module directory even when vendoring is in use. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Rafael Zago <rafaelvzago@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1348