[release-1.26] Make sure a correct helm values file is used#1305
Merged
istio-testing merged 2 commits intoistio-ecosystem:release-1.26from Oct 23, 2025
Merged
Conversation
It's possible to define a helm values file via HELM_VALUES_FILE env variable so we have to obey that when patching the file. We also need an option to disable the patching for ossm. Signed-off-by: Filip Brychta <fbrychta@redhat.com>
Signed-off-by: Filip Brychta <fbrychta@redhat.com>
FilipB
approved these changes
Oct 23, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.26 #1305 +/- ##
===============================================
Coverage ? 77.03%
===============================================
Files ? 44
Lines ? 2791
Branches ? 0
===============================================
Hits ? 2150
Misses ? 531
Partials ? 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 23, 2025
* upstream/release-1.26: [release-1.26] Make sure a correct helm values file is used (istio-ecosystem#1305)
openshift-service-mesh-bot
pushed a commit
to openshift-service-mesh-bot/sail-operator
that referenced
this pull request
Oct 23, 2025
* upstream/release-1.26: [release-1.26] Make sure a correct helm values file is used (istio-ecosystem#1305)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1297