Adding documentation specific to migrate from sidecar to ambient mode using the Sail Operator by fjglira · Pull Request #1275 · istio-ecosystem/sail-operator

fjglira · 2025-10-14T15:23:42Z

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #

Additional information:

codecov · 2025-10-14T15:27:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.91%. Comparing base (5bf66f4) to head (0994046).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1275      +/-   ##
==========================================
+ Coverage   77.59%   77.91%   +0.31%     
==========================================
  Files          44       44              
  Lines        2834     2834              
==========================================
+ Hits         2199     2208       +9     
+ Misses        526      520       -6     
+ Partials      109      106       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

docs/migrate-from-sidecar-to-ambient/migration.adoc

pbajjuri20 · 2025-10-15T03:25:05Z

docs/migrate-from-sidecar-to-ambient/migration.adoc

+[source,console]
+----
+# Check for HBONE is enable in sidecar
+$ kubectl get pod $(kubectl get pods -n bookinfo -l app=reviews -o jsonpath='{.items[0].metadata.name}') -n bookinfo -o yaml | yq '.spec.containers[] | select(.name=="istio-proxy") | .env[] | select(.name=="PROXY_CONFIG")'


I don't see any output :(

docs/migrate-from-sidecar-to-ambient/migration.adoc

sridhargaddam

Thanks for the PR @fjglira

Initial pass, will continue to review...

docs/migrate-from-sidecar-to-ambient/migration.adoc

Add specific documentation for migrate from sidecar to ambient mode Signed-off-by: Francisco Herrera <fjglira@gmail.com> Update documentation Signed-off-by: Francisco Herrera <fjglira@gmail.com> Improve and complete the Documentation about migrating from sidecar to ambient Signed-off-by: Francisco Herrera <fjglira@gmail.com> Fix some example code Signed-off-by: Francisco Herrera <fjglira@gmail.com> Adding some validations steps Signed-off-by: Francisco Herrera <fjglira@gmail.com> Fix lint Signed-off-by: Francisco Herrera <fjglira@gmail.com>

… Operator Documentation update, adding the adoc document and be sure that all the comments meet the Sail Operator criteria Signed-off-by: Francisco Herrera <fjglira@gmail.com>

All code blocks where wrong, I fixe them to meet the ascii format Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Move to a different folder Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Move the migration doc to a hiw own folder Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Delete images Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Adding some modifications after running the steps Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Indent correctly table of contents Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Changes and improvements to the doc based on the review and in the meeting Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com>

fjglira · 2025-10-20T13:55:43Z

Hey @sridhargaddam I did all the changes from the review. Please take a look

sridhargaddam

Thanks @fjglira for addressing all the review comments.

This is blocking the merge after the approval. We can still still test again everything before moving this document

docs/migrate-from-sidecar-to-ambient/migration.adoc

… using the Sail Operator (istio-ecosystem#1275) * Adding Documentation for Migration from Sidecar to Ambient Add specific documentation for migrate from sidecar to ambient mode Signed-off-by: Francisco Herrera <fjglira@gmail.com> Update documentation Signed-off-by: Francisco Herrera <fjglira@gmail.com> Improve and complete the Documentation about migrating from sidecar to ambient Signed-off-by: Francisco Herrera <fjglira@gmail.com> Fix some example code Signed-off-by: Francisco Herrera <fjglira@gmail.com> Adding some validations steps Signed-off-by: Francisco Herrera <fjglira@gmail.com> Fix lint Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding migration from sidecar to ambient documentation using the Sail Operator Documentation update, adding the adoc document and be sure that all the comments meet the Sail Operator criteria Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix code blocks in migration doc All code blocks where wrong, I fixe them to meet the ascii format Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Move document to his own folder Move to a different folder Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Move document Move the migration doc to a hiw own folder Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Delete non needed images Delete images Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Changes from review Adding some modifications after running the steps Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix table of contents Indent correctly table of contents Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Changes from review Changes and improvements to the doc based on the review and in the meeting Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix table of content Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Changes from review Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Signed-off-by: Rafael Zago <rafaelvzago@gmail.com>

… using the Sail Operator (istio-ecosystem#1275) * Adding Documentation for Migration from Sidecar to Ambient Add specific documentation for migrate from sidecar to ambient mode Signed-off-by: Francisco Herrera <fjglira@gmail.com> Update documentation Signed-off-by: Francisco Herrera <fjglira@gmail.com> Improve and complete the Documentation about migrating from sidecar to ambient Signed-off-by: Francisco Herrera <fjglira@gmail.com> Fix some example code Signed-off-by: Francisco Herrera <fjglira@gmail.com> Adding some validations steps Signed-off-by: Francisco Herrera <fjglira@gmail.com> Fix lint Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Adding migration from sidecar to ambient documentation using the Sail Operator Documentation update, adding the adoc document and be sure that all the comments meet the Sail Operator criteria Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix code blocks in migration doc All code blocks where wrong, I fixe them to meet the ascii format Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Move document to his own folder Move to a different folder Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Move document Move the migration doc to a hiw own folder Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Delete non needed images Delete images Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Changes from review Adding some modifications after running the steps Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix table of contents Indent correctly table of contents Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Changes from review Changes and improvements to the doc based on the review and in the meeting Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Fix table of content Signed-off-by: Francisco Herrera <fjglira@gmail.com> * Changes from review Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com> --------- Signed-off-by: Francisco Herrera <fjglira@gmail.com> Signed-off-by: Daniel Grimm <dgrimm@redhat.com>

fjglira requested a review from a team as a code owner October 14, 2025 15:23

istio-testing added the size/XXL label Oct 14, 2025

fjglira mentioned this pull request Oct 14, 2025

Adding Documentation for Migration from Sidecar to Ambient openshift-service-mesh/sail-operator#542

Closed

6 tasks

istio-testing added size/XS size/XXL and removed size/XXL size/XS labels Oct 14, 2025

pbajjuri20 requested changes Oct 15, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

pbajjuri20 previously requested changes Oct 15, 2025

View reviewed changes

MaxBab reviewed Oct 15, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

sridhargaddam reviewed Oct 15, 2025

View reviewed changes

sridhargaddam reviewed Oct 16, 2025

View reviewed changes

sridhargaddam reviewed Oct 19, 2025

View reviewed changes

fjglira added 11 commits October 20, 2025 15:17

Adding migration from sidecar to ambient documentation using the Sail…

a3038e4

… Operator Documentation update, adding the adoc document and be sure that all the comments meet the Sail Operator criteria Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Fix code blocks in migration doc

424080c

All code blocks where wrong, I fixe them to meet the ascii format Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Move document to his own folder

d866ce7

Move to a different folder Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Move document

a26e734

Move the migration doc to a hiw own folder Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Delete non needed images

1bf60e4

Delete images Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Changes from review

b0ed4fe

Adding some modifications after running the steps Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Fix table of contents

0fa8473

Indent correctly table of contents Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Changes from review

9e4cebf

Changes and improvements to the doc based on the review and in the meeting Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Fix table of content

2a6ff91

Signed-off-by: Francisco Herrera <fjglira@gmail.com>

Changes from review

0994046

Changes from review Signed-off-by: Francisco Herrera <fjglira@gmail.com>

fjglira force-pushed the adding-migrate-sidecar-to-ambient branch from 70520f1 to 0994046 Compare October 20, 2025 13:46

fjglira requested review from MaxBab, pbajjuri20 and sridhargaddam October 20, 2025 15:10

sridhargaddam approved these changes Oct 21, 2025

View reviewed changes

istio-testing merged commit beff729 into istio-ecosystem:main Oct 21, 2025
17 checks passed

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

mkralik3 reviewed Oct 21, 2025

View reviewed changes

docs/migrate-from-sidecar-to-ambient/migration.adoc Show resolved Hide resolved

Conversation

fjglira commented Oct 14, 2025

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Additional information:

Uh oh!

codecov bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

pbajjuri20 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sridhargaddam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fjglira commented Oct 20, 2025

Uh oh!

sridhargaddam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Oct 14, 2025 •

edited

Loading