fix(e2e): Add cleanup trap to prevent false positives in CI test runs

[fjglira]

The e2e test script was storing the Ginkgo exit code but could still exit unexpectedly before cleanup, causing CI to mark incomplete test runs as successful (false positives).

What type of PR is this?

• Enhancement / New Feature
• Bug Fix
• Refactor
• Optimization
• Test
• Documentation Update

What this PR does / why we need it:

Problem:
The e2e test script was storing the Ginkgo exit code, but could still exit unexpectedly before cleanup, causing CI to mark incomplete test runs as successful (false positives).

Solution:

• Added a cleanup() function with trap cleanup EXIT INT TERM to ensure uninstall always runs
• Moved cleanup logic to the trap so it executes on normal exit, interrupts, and terminations
• Simplified the main flow to immediately exit with the captured Ginkgo exit code
• Cleanup errors are suppressed to preserve the original test result

Result:

• CI now correctly reflects test failures and interruptions
• JUnit reports are still generated and cleanup always occurs
• No more false positive test results from incomplete runs

Which issue(s) this PR fixes:

Fixes #1226

Related Issue/PR #

Additional information:

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.54%. Comparing base (749d908) to head (3bbde83).
⚠️ Report is 83 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
+ Coverage   77.39%   77.54%   +0.14%     
==========================================
  Files          44       44              
  Lines        2823     2823              
==========================================
+ Hits         2185     2189       +4     
+ Misses        529      526       -3     
+ Partials      109      108       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ctartici]

lgtm

[istio-testing]

In response to a cherrypick label: new pull request created: #1232

[FilipB]

/cherry-pick release-1.26

[istio-testing]

In response to a cherrypick label: #1227 failed to apply on top of branch "release-1.26":

Applying: fix(e2e): Add cleanup trap to prevent false positives in CI test runs
Using index info to reconstruct a base tree...
M	tests/e2e/common-operator-integ-suite.sh
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/common-operator-integ-suite.sh
CONFLICT (content): Merge conflict in tests/e2e/common-operator-integ-suite.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix(e2e): Add cleanup trap to prevent false positives in CI test runs

[istio-testing]

In response to a cherrypick label: new issue created for failed cherrypick: #1406

[istio-testing]

@FilipB: #1227 failed to apply on top of branch "release-1.26":

Applying: fix(e2e): Add cleanup trap to prevent false positives in CI test runs
Using index info to reconstruct a base tree...
M	tests/e2e/common-operator-integ-suite.sh
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/common-operator-integ-suite.sh
CONFLICT (content): Merge conflict in tests/e2e/common-operator-integ-suite.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix(e2e): Add cleanup trap to prevent false positives in CI test runs

Details

In response to this:

/cherry-pick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[istio-testing]

In response to a cherrypick label: #1227 failed to apply on top of branch "release-1.27":

Applying: fix(e2e): Add cleanup trap to prevent false positives in CI test runs
Using index info to reconstruct a base tree...
M	tests/e2e/common-operator-integ-suite.sh
Falling back to patching base and 3-way merge...
Auto-merging tests/e2e/common-operator-integ-suite.sh
CONFLICT (content): Merge conflict in tests/e2e/common-operator-integ-suite.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix(e2e): Add cleanup trap to prevent false positives in CI test runs

[istio-testing]

@FilipB: new issue created for failed cherrypick: #1407

Details

In response to this:

/cherry-pick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[istio-testing]

In response to a cherrypick label: new issue created for failed cherrypick: #1408