Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envoy to return 400 status instead of dropping request #92

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

tylerschultz
Copy link

Cause Envoy to return 400 status code when accessing callback url
when session is expired. This may happen if the user is redirected to
the IdP and takes more time to log in than the session timeout

Fixes #91

Signed-off-by: Tyler Schultz [email protected]

Cause Envoy to return 400 status code when accessing callback url
when session is expired. This may happen if the user is redirected to
the IdP and takes more time to log in than the session timeout

Fixes #91

Signed-off-by: Tyler Schultz <[email protected]>
@googlebot
Copy link
Collaborator

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tylerschultz
To complete the pull request process, please assign brenodemedeiros
You can assign the PR to them by writing /assign @brenodemedeiros in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: no CLA negative status label Apr 9, 2020
@margocrawf
Copy link

@googlebot I fixed it.

@googlebot
Copy link
Collaborator

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@margocrawf
Copy link

@googlebot I consent.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA positive status and removed cla: no CLA negative status labels Apr 9, 2020
@tylerschultz tylerschultz merged commit db8d779 into master Apr 9, 2020
@tylerschultz tylerschultz deleted the session-timeout-bug branch April 9, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA positive status size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authservice should not drop requests when invoking callback url after session expiration
4 participants