Issue60 config uris as strings 2 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: peterhaochen47 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- Renamed `oidc.logout.redirect_to_uri` config option to `redirect_uri` - Renamed `authorization`, `token`, and `callback` config options to `authorization_uri`, `token_uri`, and `callback_uri` - Deleted the unused `jwks_uri` config option - The `authorization_uri`, `token_uri`, and `callback_uri` config options became simple strings instead of `Endpoint` objects [Issue #60] Signed-off-by: Peter Chen <[email protected]>
- Remove unneeded fixtures [Issue #60] Signed-off-by: Tyler Schultz <[email protected]>
- Make constant static - Inline functions are labeled with `inline` keyword - Use correct return type for move assignment operator [Issue #60] Signed-off-by: Peter Chen <[email protected]>
[Issue #60] Signed-off-by: Tyler Schultz <[email protected]>
This avoids a conflict we saw in gcc between the getter "Uri::PathQueryFragment" and the class definition PathQueryFragment. [Issue #60] Signed-off-by: Peter Chen <[email protected]>
peterhaochen47
force-pushed
the
issue60_config_uris_as_strings-2
branch
from
8f2991b to
21b5177
Compare
|
/lgtm |
|
@peterhaochen47: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
nacx
added a commit
to nacx/authservice
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60