Fix flaky file watcher test #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test method `waitForRead` was sometimes signaling due to accumulated reads, even it was inteded to wait for a read after a new content was set in the mock file. This fixes it by waiting to singal read happened when the read content is the same as the expected one. Signed-off-by: Sergi Castro <[email protected]>
sergicastro
force-pushed
the
flaky-file-watcher-test
branch
from
f2c27ca
to
68937d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=======================================
Coverage ? 90.64%
=======================================
Files ? 25
Lines ? 1603
Branches ? 0
=======================================
Hits ? 1453
Misses ? 107
Partials ? 43 |
|
I will join both methods to a single one (set and wait). |
Signed-off-by: Sergi Castro <[email protected]>
nacx
approved these changes
May 14, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test method
waitForReadwas sometimes signaling due to accumulated reads, even it was inteded to wait for a read after a new content was set in the mock file.This fixes it by waiting to singal read happened when the read content is the same as the expected one.